--===============6359564447520148225== Content-Type: multipart/alternative; boundary="===============7110845434420505696==" --===============7110845434420505696== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127932/#review96004 ----------------------------------------------------------- Ship it! Ship It! - Aurélien Gâteau On mai 24, 2016, 5:10 après-midi, René J.V. Bertin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127932/ > ----------------------------------------------------------- > > (Updated mai 24, 2016, 5:10 après-midi) > > > Review request for Gwenview and KDE Software on Mac OS X. > > > Repository: gwenview > > > Description > ------- > > This patch takes care of 2 things on OS X: > - it prevents the application icon (installed via `ecm_add_app_icon`) to be replaced by an empty icon in main (`QApplication::setWindowIcon(QIcon::fromTheme(QStringLiteral("gwenview")))`) > - it installs an extended `Info.plist` and an event filter that catches `QFileOpenEvent`s so that gwenview can open documents served through LaunchServices, e.g. when using the Finder's "Open With" function. This same code should also work under MS Windows. > > > Diffs > ----- > > app/CMakeLists.txt dcf486f > app/main.cpp f9c87c3 > app/mainwindow.h 6d252f9 > app/mainwindow.cpp 7b30c4e > > Diff: https://git.reviewboard.kde.org/r/127932/diff/ > > > Testing > ------- > > With OS X 10.9.5, Qt 5.6.0 and K5FWs 5.20.0 . It currently doesn't attempt to queue incoming requests in some sort of temporal buffer so that it can open groups of documents. > > > Thanks, > > René J.V. Bertin > > --===============7110845434420505696== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127932/ |
Ship it!
Ship It!
- Aurélien Gâteau
On mai 24th, 2016, 5:10 après-midi CEST, René J.V. Bertin wrote:
Review request for Gwenview and KDE Software on Mac OS X.
By René J.V. Bertin.
Updated mai 24, 2016, 5:10 après-midi
Repository:
gwenview
Description
Testing
Diffs
|