--===============4295134733520023646== Content-Type: multipart/alternative; boundary="===============0267196578828860506==" --===============0267196578828860506== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit > On jan. 6, 2016, 11:14 après-midi, Aurélien Gâteau wrote: > > As a first step toward turning this into a library, you could move all the dbus code to a separate class. > > Martin Klapetek wrote: > See https://git.reviewboard.kde.org/r/126650/ Ah cool, looks good! - Aurélien ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126627/#review90716 ----------------------------------------------------------- On jan. 4, 2016, 9:25 après-midi, Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126627/ > ----------------------------------------------------------- > > (Updated jan. 4, 2016, 9:25 après-midi) > > > Review request for Gwenview and Kai Uwe Broulik. > > > Bugs: 334525 > http://bugs.kde.org/show_bug.cgi?id=334525 > > > Repository: gwenview > > > Description > ------- > > This is a better approach to fix bug 334525 than > https://git.reviewboard.kde.org/r/125910/ which forces > a default reason (which is user visible). > > With this new patch Gwenview will set a proper reason > why is it inhibitting the screensaver ("Full Screen Presentation") > and will use the DBus directly rather than the obsolete > KNotificationRestrictions API. > > > Diffs > ----- > > app/mainwindow.cpp 7b30c4e > > Diff: https://git.reviewboard.kde.org/r/126627/diff/ > > > Testing > ------- > > PowerDevil correctly shows that Gwenview is inhibitting > the PM because "Full Screen Presentation". > > > Thanks, > > Martin Klapetek > > --===============0267196578828860506== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126627/

On janvier 6th, 2016, 11:14 après-midi CET, Aurélien Gâteau wrote:
As a first step toward turning this into a library, you could move all the dbus code to a separate class.
On janvier 6th, 2016, 11:35 après-midi CET, Martin Klapetek wrote:
See https://git.reviewboard.kde.org/r/126650/

Ah cool, looks good!

- Aurélien

On janvier 4th, 2016, 9:25 après-midi CET, Martin Klapetek wrote:

Review request for Gwenview and Kai Uwe Broulik.

By Martin Klapetek.

Updated jan. 4, 2016, 9:25 après-midi

Bugs: 334525

Repository: gwenview

Description

This is a better approach to fix bug 334525 than https://git.reviewboard.kde.org/r/125910/ which forces a default reason (which is user visible).

With this new patch Gwenview will set a proper reason why is it inhibitting the screensaver ("Full Screen Presentation") and will use the DBus directly rather than the obsolete KNotificationRestrictions API.

Testing

PowerDevil correctly shows that Gwenview is inhibitting the PM because "Full Screen Presentation".

Diffs

app/mainwindow.cpp (7b30c4e)

--===============0267196578828860506==-- --===============4295134733520023646== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KR3dlbnZpZXct ZGV2ZWwgbWFpbGluZyBsaXN0Ckd3ZW52aWV3LWRldmVsQGtkZS5vcmcKaHR0cHM6Ly9tYWlsLmtk ZS5vcmcvbWFpbG1hbi9saXN0aW5mby9nd2Vudmlldy1kZXZlbAo= --===============4295134733520023646==--