[prev in list] [next in list] [prev in thread] [next in thread]
List: gwenview-devel
Subject: Re: Review Request 126627: Replace screensaver inhibition by direct dbus calls
From: Thomas_Lübking <thomas.luebking () gmail ! com>
Date: 2016-01-05 15:35:04
Message-ID: 20160105153504.18870.1229 () mimi ! kde ! org
[Download RAW message or body]
--===============6956417619986927867==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Jan. 4, 2016, 10:07 p.m., Albert Astals Cid wrote:
> > Don't we really have something other than this complex code for apps to use? It'd \
> > be sad to see people copy&pasting this with subtle mistakes all over :/
>
> Martin Klapetek wrote:
> There is a thing in solid that is unfinished (there's a big chunk
> of code with "WITH_NEW_POWER_ASYNC_API" cmake switch) and apparently
> no solid maintainer to actually finished it.
>
> On the other hand, this ain't no complex code, it's a simple dbus
> call with storing the reply and another dbus call sending the stored
> reply. It's a long boring code, but not complex.
>
> Martin Gräßlin wrote:
> we could use your code to turn it into a library ;-)
>
> Thomas Lübking wrote:
> Like adding a PowerManagement flag to KNotificationRestrictions as well as a new \
> constructor KNotificationRestrictions(QString reason, Services \
> control=NonCriticalServices, QObject *parent=0)
> Seems a natural solution =)
>
> Martin Klapetek wrote:
> I actually wanted to get rid of KNotificationRestriction,
> it's used only by Gwenview and somehow really don't belong
> to KNotifications anyway, it's disabling PM after all.
>
> @Martin G - well there is half finished thing in solid, it
> needs someone to step up to it and decide what to do with it.
=> KIdleTime?
The feature itself could be interesting for okular or some video players as well - \
esp. in tier1, yesno?
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126627/#review90599
-----------------------------------------------------------
On Jan. 4, 2016, 8:25 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126627/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2016, 8:25 p.m.)
>
>
> Review request for Gwenview and Kai Uwe Broulik.
>
>
> Bugs: 334525
> http://bugs.kde.org/show_bug.cgi?id=334525
>
>
> Repository: gwenview
>
>
> Description
> -------
>
> This is a better approach to fix bug 334525 than
> https://git.reviewboard.kde.org/r/125910/ which forces
> a default reason (which is user visible).
>
> With this new patch Gwenview will set a proper reason
> why is it inhibitting the screensaver ("Full Screen Presentation")
> and will use the DBus directly rather than the obsolete
> KNotificationRestrictions API.
>
>
> Diffs
> -----
>
> app/mainwindow.cpp 7b30c4e
>
> Diff: https://git.reviewboard.kde.org/r/126627/diff/
>
>
> Testing
> -------
>
> PowerDevil correctly shows that Gwenview is inhibitting
> the PM because "Full Screen Presentation".
>
>
> Thanks,
>
> Martin Klapetek
>
>
--===============6956417619986927867==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126627/">https://git.reviewboard.kde.org/r/126627/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 4th, 2016, 10:07 p.m. UTC, <b>Albert \
Astals Cid</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Don't we really have something other than this complex \
code for apps to use? It'd be sad to see people copy&pasting this with subtle \
mistakes all over :/</p></pre> </blockquote>
<p>On January 5th, 2016, 5:14 a.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There \
is a thing in solid that is unfinished (there's a big chunk of code with \
"WITH_NEW_POWER_ASYNC_API" cmake switch) and apparently no solid maintainer to \
actually finished it.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">On the other hand, this ain't no \
complex code, it's a simple dbus call with storing the reply and another dbus call \
sending the stored reply. It's a long boring code, but not complex.</p></pre>
</blockquote>
<p>On January 5th, 2016, 6:52 a.m. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">we \
could use your code to turn it into a library ;-)</p></pre> </blockquote>
<p>On January 5th, 2016, 8:51 a.m. UTC, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Like adding a \
PowerManagement flag to KNotificationRestrictions as well as a new constructor \
KNotificationRestrictions(QString reason, Services control=NonCriticalServices, \
QObject *parent=0)
Seems a natural solution =)</pre>
</blockquote>
<p>On January 5th, 2016, 3:14 p.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
actually wanted to get rid of KNotificationRestriction, it's used only by Gwenview \
and somehow really don't belong to KNotifications anyway, it's disabling PM after \
all.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">@Martin G - well there is half finished thing in \
solid, it needs someone to step up to it and decide what to do with it.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">=> \
KIdleTime? The feature itself could be interesting for okular or some video players \
as well - esp. in tier1, yesno?</p></pre> <br />
<p>- Thomas</p>
<br />
<p>On January 4th, 2016, 8:25 p.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Gwenview and Kai Uwe Broulik.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Jan. 4, 2016, 8:25 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=334525">334525</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
gwenview
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is a better approach to fix bug 334525 than \
https://git.reviewboard.kde.org/r/125910/ which forces a default reason (which is \
user visible).</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">With this new patch Gwenview will set a \
proper reason why is it inhibitting the screensaver ("Full Screen Presentation")
and will use the DBus directly rather than the obsolete
KNotificationRestrictions API.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">PowerDevil correctly shows that Gwenview is \
inhibitting the PM because "Full Screen Presentation".</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>app/mainwindow.cpp <span style="color: grey">(7b30c4e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126627/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6956417619986927867==--
[Attachment #3 (text/plain)]
_______________________________________________
Gwenview-devel mailing list
Gwenview-devel@kde.org
https://mail.kde.org/mailman/listinfo/gwenview-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic