'Review Request 126627: Replace screensaver inhibition by direct dbus calls'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gwenview-devel
Subject:    Review Request 126627: Replace screensaver inhibition by direct dbus calls
From:       "Martin Klapetek" <martin.klapetek () gmail ! com>
Date:       2016-01-04 20:07:40
Message-ID: 20160104200740.6499.78732 () mimi ! kde ! org
[Download RAW message or body]

--===============6743294950516191695==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126627/
-----------------------------------------------------------

Review request for Gwenview and Kai Uwe Broulik.

Bugs: 334525
    http://bugs.kde.org/show_bug.cgi?id=334525

Repository: gwenview

Description
-------

This is a better approach to fix bug 334525 than
https://git.reviewboard.kde.org/r/125910/ which forces
a default reason (which is user visible).

With this new patch Gwenview will set a proper reason
why is it inhibitting the screensaver ("Full Screen Presentation")
and will use the DBus directly rather than the obsolete
KNotificationRestrictions API.

Diffs
-----

  app/mainwindow.cpp 7b30c4e 

Diff: https://git.reviewboard.kde.org/r/126627/diff/

Testing
-------

PowerDevil correctly shows that Gwenview is inhibitting
the PM because "Full Screen Presentation".

Thanks,

Martin Klapetek

--===============6743294950516191695==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126627/">https://git.reviewboard.kde.org/r/126627/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Gwenview and Kai Uwe Broulik.</div>
<div>By Martin Klapetek.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=334525">334525</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
gwenview
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is a better approach to fix bug 334525 than \
https://git.reviewboard.kde.org/r/125910/ which forces a default reason (which is \
user visible).</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">With this new patch Gwenview will set a \
proper reason why is it inhibitting the screensaver ("Full Screen Presentation")
and will use the DBus directly rather than the obsolete
KNotificationRestrictions API.</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">PowerDevil correctly shows that Gwenview is \
inhibitting the PM because "Full Screen Presentation".</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>app/mainwindow.cpp <span style="color: grey">(7b30c4e)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126627/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============6743294950516191695==--

[Attachment #3 (text/plain)]

_______________________________________________
Gwenview-devel mailing list
Gwenview-devel@kde.org
https://mail.kde.org/mailman/listinfo/gwenview-devel

[prev in list] [next in list] [prev in thread] [next in thread] 