[prev in list] [next in list] [prev in thread] [next in thread]
List: gwenview-devel
Subject: Re: Review Request 125216: Fix reading the ui.rc and as a result fix the UI.
From: "Luigi Toscano" <luigi.toscano () tiscali ! it>
Date: 2015-10-10 14:00:43
Message-ID: 20151010140043.17685.30661 () mimi ! kde ! org
[Download RAW message or body]
--===============2221361033681205176==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125216/#review86633
-----------------------------------------------------------
This review reverted the original change; a more general fix which kept the change \
was proposed in https://git.reviewboard.kde.org/r/125524/ and applied. This review \
can be now discarded.
- Luigi Toscano
On Ott. 7, 2015, 11:01 p.m., Shlomi Fish wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125216/
> -----------------------------------------------------------
>
> (Updated Ott. 7, 2015, 11:01 p.m.)
>
>
> Review request for Gwenview and Ivan Čukić.
>
>
> Repository: gwenview
>
>
> Description
> -------
>
> Fix reading the ui.rc file - without it, most of the UI is missing.
>
>
> Diffs
> -----
>
> app/main.cpp 806fcab
>
> Diff: https://git.reviewboard.kde.org/r/125216/diff/
>
>
> Testing
> -------
>
> See https://bugs.kde.org/show_bug.cgi?id=352622 - gwenview seems to run fine and \
> much better with this patch. I tried running rotate, rescale and crop - all are \
> working fine.
>
> Thanks,
>
> Shlomi Fish
>
>
--===============2221361033681205176==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125216/">https://git.reviewboard.kde.org/r/125216/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
review reverted the original change; a more general fix which kept the change was \
proposed in https://git.reviewboard.kde.org/r/125524/ and applied. This review can be \
now discarded.</p></pre> <br />
<p>- Luigi Toscano</p>
<br />
<p>On ottobre 7th, 2015, 11:01 p.m. CEST, Shlomi Fish wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Gwenview and Ivan Čukić.</div>
<div>By Shlomi Fish.</div>
<p style="color: grey;"><i>Updated Ott. 7, 2015, 11:01 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
gwenview
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Fix reading the ui.rc file - without it, most of the \
UI is missing.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">See https://bugs.kde.org/show_bug.cgi?id=352622 - \
gwenview seems to run fine and much better with this patch. I tried running rotate, \
rescale and crop - all are working fine.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>app/main.cpp <span style="color: grey">(806fcab)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125216/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2221361033681205176==--
[Attachment #3 (text/plain)]
_______________________________________________
Gwenview-devel mailing list
Gwenview-devel@kde.org
https://mail.kde.org/mailman/listinfo/gwenview-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic