'Re: Review Request 123245: Syncing the application name with the name of the desktop file'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gwenview-devel
Subject:    Re: Review Request 123245: Syncing the application name with the name of the desktop file
From:       Ivan Čukić <ivan.cukic () kde ! org>
Date:       2015-04-09 7:57:52
Message-ID: 20150409075752.31692.65041 () mimi ! kde ! org
[Download RAW message or body]

--===============8022842501460903284==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123245/
-----------------------------------------------------------

(Updated April 9, 2015, 7:57 a.m.)

Status
------

This change has been marked as submitted.

Review request for Gwenview.

Changes
-------

Submitted with commit 78e4e57af3a5476dd949797c559a3d25d8ce50a1 by Aurélien Gâteau \
on behalf of Ivan ?uki? to branch master.

Repository: gwenview

Description
-------

Gwenview application name stayed 'gwenview' while the .desktop file switched to the \
org.kde.*something* naming scheme.

While currently not that important - in the recent future, syncing these two will be \
                needed for the application to properly work with the things like:
- recent/favourite/high scored documents for gwenview in the task-bar
- remembering the prefered application for specific files
- probably something else that I can not remember atm :)

Diffs
-----

  app/main.cpp 07de427 

Diff: https://git.reviewboard.kde.org/r/123245/diff/

Testing
-------

Thanks,

Ivan Čukić

--===============8022842501460903284==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123245/">https://git.reviewboard.kde.org/r/123245/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Gwenview.</div>
<div>By Ivan Čukić.</div>

<p style="color: grey;"><i>Updated April 9, 2015, 7:57 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 78e4e57af3a5476dd949797c559a3d25d8ce50a1 by \
Aurélien Gâteau on behalf of Ivan ?uki? to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
gwenview
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Gwenview application name stayed 'gwenview' while the \
.desktop file switched to the org.kde.<em style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">something</em> naming \
scheme.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">While currently not that important - in the recent \
future, syncing these two will be needed for the application to properly work with \
                the things like:
- recent/favourite/high scored documents for gwenview in the task-bar
- remembering the prefered application for specific files
- probably something else that I can not remember atm :)</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>app/main.cpp <span style="color: grey">(07de427)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123245/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8022842501460903284==--

[Attachment #3 (text/plain)]

_______________________________________________
Gwenview-devel mailing list
Gwenview-devel@kde.org
https://mail.kde.org/mailman/listinfo/gwenview-devel

[prev in list] [next in list] [prev in thread] [next in thread] 