[prev in list] [next in list] [prev in thread] [next in thread]
List: gwenview-devel
Subject: Re: Review Request 122873: Fix for wrong rotation of RAW images
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2015-03-13 16:13:45
Message-ID: 20150313161345.27069.90023 () mimi ! kde ! org
[Download RAW message or body]
--===============5127747811526303522==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On March 13, 2015, 12:35 p.m., David Edmundson wrote:
> > In that bug report that you linked to there's a commit fixing it which is in 5.4 \
> > which is out.
> >
> > It also says:
> > > if an application is handling the rotation itself right now the image will be \
> > > rotated twice.
> >
> >
> > This seems like it would be a bad idea to merge this then?
>
> Martin Kyral wrote:
> Yes and that fix actually broke RAW preview in gwenview.
>
> This patch does nothing more, than disabling the additional rotation for RAW \
> previews (which is the broken case) while for all other formats there's no change \
> at all.
Thanks. Seems sensible then. A comment in the code explaining why we have this logic \
be useful for future devs.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122873/#review77412
-----------------------------------------------------------
On March 9, 2015, 4:25 p.m., Martin Kyral wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122873/
> -----------------------------------------------------------
>
> (Updated March 9, 2015, 4:25 p.m.)
>
>
> Review request for Gwenview.
>
>
> Repository: gwenview
>
>
> Description
> -------
>
> Displaying of RAW images in gwenview was broken by \
> https://bugreports.qt.io/browse/QTBUG-37946. I am fixing (or rather workarounding \
> it) by blocking EXIF rotation iff the loaded image is RAW.
>
> Diffs
> -----
>
> lib/document/loadingdocumentimpl.cpp cc8bea9
> lib/thumbnailprovider/thumbnailgenerator.h 4571832
> lib/thumbnailprovider/thumbnailgenerator.cpp 54875f5
>
> Diff: https://git.reviewboard.kde.org/r/122873/diff/
>
>
> Testing
> -------
>
> Tested with various RAW files, used previously to test the RAW loading support \
> itself & with some jpeg files (including \
> https://github.com/recurser/exif-orientation-examples.git).
> Seems OK.
>
> Nevertheless, the fix is not complete as jpeg files extracted from the RAWs using \
> 'dcraw -e' are still mis-rotated.
>
> Thanks,
>
> Martin Kyral
>
>
--===============5127747811526303522==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122873/">https://git.reviewboard.kde.org/r/122873/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 13th, 2015, 12:35 p.m. UTC, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">In that bug report that you linked to there's a commit \
fixing it which is in 5.4 which is out.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">It also says:</p> \
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid \
#bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">if an application is handling the rotation itself right now the image will \
be rotated twice.</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This seems like it would be a bad idea to merge this \
then?</p></pre> </blockquote>
<p>On March 13th, 2015, 4:10 p.m. UTC, <b>Martin Kyral</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes \
and that fix actually broke RAW preview in gwenview.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
patch does nothing more, than disabling the additional rotation for RAW previews \
(which is the broken case) while for all other formats there's no change at \
all.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Thanks. Seems sensible then. A comment in the code explaining why we have \
this logic be useful for future devs.</p></pre> <br />
<p>- David</p>
<br />
<p>On March 9th, 2015, 4:25 p.m. UTC, Martin Kyral wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Gwenview.</div>
<div>By Martin Kyral.</div>
<p style="color: grey;"><i>Updated March 9, 2015, 4:25 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
gwenview
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Displaying of RAW images in gwenview was broken by \
https://bugreports.qt.io/browse/QTBUG-37946. I am fixing (or rather workarounding it) \
by blocking EXIF rotation iff the loaded image is RAW.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested with various RAW files, used previously to test \
the RAW loading support itself & with some jpeg files (including \
https://github.com/recurser/exif-orientation-examples.git).</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Seems \
OK.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Nevertheless, the fix is not complete as jpeg files \
extracted from the RAWs using 'dcraw -e' are still mis-rotated.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>lib/document/loadingdocumentimpl.cpp <span style="color: \
grey">(cc8bea9)</span></li>
<li>lib/thumbnailprovider/thumbnailgenerator.h <span style="color: \
grey">(4571832)</span></li>
<li>lib/thumbnailprovider/thumbnailgenerator.cpp <span style="color: \
grey">(54875f5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122873/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5127747811526303522==--
[Attachment #3 (text/plain)]
_______________________________________________
Gwenview-devel mailing list
Gwenview-devel@kde.org
https://mail.kde.org/mailman/listinfo/gwenview-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic