'Re: Review Request 120056: Fix build with libjpeg-9.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gwenview-devel
Subject:    Re: Review Request 120056: Fix build with libjpeg-9.
From:       Aurélien Gâteau <agateau () kde ! org>
Date:       2014-09-16 8:01:33
Message-ID: 20140916080133.22584.49578 () probe ! kde ! org
[Download RAW message or body]

--===============0574477737295414927==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120056/#review66646
-----------------------------------------------------------

Ship it!

Looks good, thanks!

- Aurélien Gâteau

On sep. 11, 2014, 10:08 après-midi, Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120056/
> -----------------------------------------------------------
> 
> (Updated sep. 11, 2014, 10:08 après-midi)
> 
> 
> Review request for Gwenview.
> 
> 
> Bugs: 338622
> http://bugs.kde.org/show_bug.cgi?id=338622
> 
> 
> Repository: gwenview
> 
> 
> Description
> -------
> 
> Otherwise, configure bails out as it does not recognise the libjpeg version.
> 
> 
> Diffs
> -----
> 
> lib/libjpeg-90/jinclude.h PRE-CREATION 
> lib/libjpeg-90/jpegint.h PRE-CREATION 
> lib/libjpeg-90/transupp.h PRE-CREATION 
> lib/libjpeg-90/transupp.c PRE-CREATION 
> lib/CMakeLists.txt 14b3e7cf1d52fb72b3886a6cfb1016cb7105828f 
> lib/libjpeg-90/README.jpeg PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/120056/diff/
> 
> 
> Testing
> -------
> 
> Builds. Runs.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
> 

--===============0574477737295414927==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120056/">https://git.reviewboard.kde.org/r/120056/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks \
good, thanks!</p></pre>  <br />

<p>- Aurélien Gâteau</p>

<br />
<p>On septembre 11th, 2014, 10:08 après-midi CEST, Michael Palimaka wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Gwenview.</div>
<div>By Michael Palimaka.</div>

<p style="color: grey;"><i>Updated sep. 11, 2014, 10:08 après-midi</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=338622">338622</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
gwenview
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Otherwise, configure bails out as it does not \
recognise the libjpeg version.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Builds. Runs.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>lib/libjpeg-90/jinclude.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>lib/libjpeg-90/jpegint.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>lib/libjpeg-90/transupp.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>lib/libjpeg-90/transupp.c <span style="color: grey">(PRE-CREATION)</span></li>

 <li>lib/CMakeLists.txt <span style="color: \
grey">(14b3e7cf1d52fb72b3886a6cfb1016cb7105828f)</span></li>

 <li>lib/libjpeg-90/README.jpeg <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120056/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============0574477737295414927==--

_______________________________________________
Gwenview-devel mailing list
Gwenview-devel@kde.org
https://mail.kde.org/mailman/listinfo/gwenview-devel

[prev in list] [next in list] [prev in thread] [next in thread] 