'Re: Review Request 119549: Allow different ways to handle zoom and position between images'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gwenview-devel
Subject:    Re: Review Request 119549: Allow different ways to handle zoom and position between images
From:       "John Zaitseff" <j.zaitseff () zap ! org ! au>
Date:       2014-08-07 16:27:34
Message-ID: 20140807162734.20974.2184 () probe ! kde ! org
[Download RAW message or body]

--===============5260587132621927133==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119549/
-----------------------------------------------------------

(Updated Aug. 7, 2014, 4:27 p.m.)

Status
------

This change has been marked as submitted.

Review request for Gwenview.

Bugs: 337262
    http://bugs.kde.org/show_bug.cgi?id=337262

Repository: gwenview

Description
-------

(Taken from bug #337262 )

Over the years, there has been much discussion about whether the zoom and position \
should be kept the same between images (see, for example, bug 293103, which I \
submitted, or bugs 291759, 294915, 321122, 327889, 331412, 334530, 337037 --- there \
may be more!).  I have even submitted a patch (with bug 293103) which was applied in \
modified form---thanks!  However, it has been subsequently broken...

I have come to realise that there are THREE main ways people like to have the zoom \
and position settings applied to successive images:

1. Each image should be opened in Zoom to Fit mode, even if the previous image was \
zoomed in or out and was panned to a different position.  This is Aurélien Gâteau's \
preferred mode of operation: call it Autofit zoom mode.

2. The zoom and position settings should be shared across all images.  New images \
should be opened with the previous image's settings.  If you go back to a previous \
image (from image B to image A, previously opened), image A's settings should be \
updated to be those of image B.  This allows you to set zoom and position on an \
image, then go back and forward to the previous and next image while retaining the \
settings.  This is MY preferred mode of operation: call it Shared mode.

3. Each image should remember its own zoom and position settings.  New images should \
be opened with the previous image's position and zoom, but if you then change image \
B's zoom/position, this is NOT passed back to image A, if you go back to that image.  \
This is Abhinav Gangwar's preferred mode of operation, and is what LockZoom \
implements in Gwenview: call it Individual mode.

I think people don't mind Autofit being the default, as long as it can be changed.  \
At the moment, doing so is very non-obvious, and the Shared mode of operation simply \
does not exist (as of 12th February 2014).

I am submitting a patch that does the following:

1. Create a config file option "ZoomMode" with ZoomMode::Autofit, ZoomMode::Shared \
and ZoomMode::Individual being the choices (Autofit is the default, per Aurélien's \
preferences).

2. Remove the now-obsolete ShowLockZoomButton and LockZoom config options.

3. Remove the Lock Zoom button: it is not visible in Autofit mode anyway, and when a \
user wants the other modes, they want it on ALL the time, not just some of the time!  \
Besides, it clutters up the interface :-)

4. Set the zoom and position settings for each image depending on the ZoomMode \
selected.

5. Add a group of three Zoom Mode radio buttons to the Image Settings configuration \
dialog page: "Autofit each image", "Shared zoom and position" and "Individual \
(per-image) zoom and position".  I think adding these radio buttons is the most \
elegant way for users to change this setting, given how non-obvious the current \
method is (as can be seen by the continual stream of bug reports!).

Diffs
-----

  app/configdialog.cpp a582695 
  app/imageviewconfigpage.ui f5e1e5a 
  app/kipiinterface.h 45fb03b 
  app/viewmainpage.cpp 7caf099 
  cmake/FindLCMS2.cmake cc17e9f 
  devdoc/CONTRIBUTING.md ffdb7f7 
  doc/index.docbook d3266b8 
  lib/archiveutils.h db79771 
  lib/cms/iccjpeg.c 1f6c4b1 
  lib/documentview/documentview.cpp 1ab8bbb 
  lib/gwenviewconfig.kcfg 92d39f7 
  lib/zoommode.h PRE-CREATION 
  lib/zoomwidget.h b181f5a 
  lib/zoomwidget.cpp da66a56 
  part/gvpart.rc 35703a7 

Diff: https://git.reviewboard.kde.org/r/119549/diff/

Testing
-------

Have compiled Gwenview GIT head with this patch on my system; tested successfully \
with all variants.

Thanks,

John Zaitseff

--===============5260587132621927133==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119549/">https://git.reviewboard.kde.org/r/119549/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Gwenview.</div>
<div>By John Zaitseff.</div>

<p style="color: grey;"><i>Updated Aug. 7, 2014, 4:27 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=337262">337262</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
gwenview
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">(Taken from bug #337262 )</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Over \
the years, there has been much discussion about whether the zoom and position should \
be kept the same between images (see, for example, bug 293103, which I submitted, or \
bugs 291759, 294915, 321122, 327889, 331412, 334530, 337037 --- there may be more!).  \
I have even submitted a patch (with bug 293103) which was applied in modified \
form---thanks!  However, it has been subsequently broken...</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
have come to realise that there are THREE main ways people like to have the zoom and \
position settings applied to successive images:</p> <ol style="padding: \
0;text-rendering: inherit;margin: 0 0 0 2em;line-height: inherit;white-space: \
normal;"> <li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;"> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Each image should be opened in Zoom to \
Fit mode, even if the previous image was zoomed in or out and was panned to a \
different position.  This is Aurélien Gâteau's preferred mode of operation: call it \
Autofit zoom mode.</p> </li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;"> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">The zoom and position settings should \
be shared across all images.  New images should be opened with the previous image's \
settings.  If you go back to a previous image (from image B to image A, previously \
opened), image A's settings should be updated to be those of image B.  This allows \
you to set zoom and position on an image, then go back and forward to the previous \
and next image while retaining the settings.  This is MY preferred mode of operation: \
call it Shared mode.</p> </li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;"> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Each image should remember its own zoom \
and position settings.  New images should be opened with the previous image's \
position and zoom, but if you then change image B's zoom/position, this is NOT passed \
back to image A, if you go back to that image.  This is Abhinav Gangwar's preferred \
mode of operation, and is what LockZoom implements in Gwenview: call it Individual \
mode.</p> </li>
</ol>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I think people don't mind Autofit being the default, \
as long as it can be changed.  At the moment, doing so is very non-obvious, and the \
Shared mode of operation simply does not exist (as of 12th February 2014).</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I am submitting a patch that does the following:</p> <ol style="padding: \
0;text-rendering: inherit;margin: 0 0 0 2em;line-height: inherit;white-space: \
normal;"> <li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;"> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Create a config file option "ZoomMode" \
with ZoomMode::Autofit, ZoomMode::Shared and ZoomMode::Individual being the choices \
(Autofit is the default, per Aurélien's preferences).</p> </li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;"> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Remove the now-obsolete \
ShowLockZoomButton and LockZoom config options.</p> </li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;"> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Remove the Lock Zoom button: it is not \
visible in Autofit mode anyway, and when a user wants the other modes, they want it \
on ALL the time, not just some of the time!  Besides, it clutters up the interface \
:-)</p> </li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;"> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Set the zoom and position settings for \
each image depending on the ZoomMode selected.</p> </li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;"> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Add a group of three Zoom Mode radio \
buttons to the Image Settings configuration dialog page: "Autofit each image", \
"Shared zoom and position" and "Individual (per-image) zoom and position".  I think \
adding these radio buttons is the most elegant way for users to change this setting, \
given how non-obvious the current method is (as can be seen by the continual stream \
of bug reports!).</p> </li>
</ol></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Have compiled Gwenview GIT head with this patch on my \
system; tested successfully with all variants.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>app/configdialog.cpp <span style="color: grey">(a582695)</span></li>

 <li>app/imageviewconfigpage.ui <span style="color: grey">(f5e1e5a)</span></li>

 <li>app/kipiinterface.h <span style="color: grey">(45fb03b)</span></li>

 <li>app/viewmainpage.cpp <span style="color: grey">(7caf099)</span></li>

 <li>cmake/FindLCMS2.cmake <span style="color: grey">(cc17e9f)</span></li>

 <li>devdoc/CONTRIBUTING.md <span style="color: grey">(ffdb7f7)</span></li>

 <li>doc/index.docbook <span style="color: grey">(d3266b8)</span></li>

 <li>lib/archiveutils.h <span style="color: grey">(db79771)</span></li>

 <li>lib/cms/iccjpeg.c <span style="color: grey">(1f6c4b1)</span></li>

 <li>lib/documentview/documentview.cpp <span style="color: \
grey">(1ab8bbb)</span></li>

 <li>lib/gwenviewconfig.kcfg <span style="color: grey">(92d39f7)</span></li>

 <li>lib/zoommode.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>lib/zoomwidget.h <span style="color: grey">(b181f5a)</span></li>

 <li>lib/zoomwidget.cpp <span style="color: grey">(da66a56)</span></li>

 <li>part/gvpart.rc <span style="color: grey">(35703a7)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119549/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============5260587132621927133==--

_______________________________________________
Gwenview-devel mailing list
Gwenview-devel@kde.org
https://mail.kde.org/mailman/listinfo/gwenview-devel

[prev in list] [next in list] [prev in thread] [next in thread] 