[prev in list] [next in list] [prev in thread] [next in thread]
List: gwenview-devel
Subject: Re: Review Request 113397: RAW preview in gwenview
From: Aurélien Gâteau <agateau () kde ! org>
Date: 2013-11-21 16:36:07
Message-ID: 20131121163607.362.31868 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Nov. 14, 2013, 4:27 p.m., Aurélien Gâteau wrote:
> > Looks good now, let's merge it in! Do you have an account on KDE git \
> > infrastructure?
>
> Aurélien Gâteau wrote:
> Regarding tests: I would like to have tests for raw files as well, but would rather \
> avoid committing them to the git repository. What do you think of hosting a big \
> archive of raw files on download.kde.org and enabling the tests only if the archive \
> has been unpacked in the proper place?
> Note: this can be done after your code is merged in.
>
> Martin Kyral wrote:
> Great! :) No, I don't have account on KDE git yet.
>
> I like the idea with the archive of raw files on download.kde.org. However, I'll \
> need to obtain some (I used mostly files downloaded from the \
> http://www.photographyblog.com/ which is OK, but surely I don't have a permission \
> of further distributing them). Of course, I'll provide some of my own photos (NEF, \
> NRW).
Maybe we can reuse Digikam test images available from \
http://digikam3rdparty.free.fr/TEST_IMAGES/RAW/ ? One could write a shell script \
downloading a few of them with wget and then add a test to DocumentTest, with a QSKIP \
message suggesting to run the script if the raw images are not there.
- Aurélien
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113397/#review43670
-----------------------------------------------------------
On Nov. 19, 2013, 10:22 a.m., Martin Kyral wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113397/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2013, 10:22 a.m.)
>
>
> Review request for Gwenview and Aurélien Gâteau.
>
>
> Repository: gwenview
>
>
> Description
> -------
>
> This is a review of patch enabling raw support in gwenview. It uses KDcraw to \
> extract the embedded jpeg preview (most of the raw formats contain it for the \
> purposes of quick viewing the photos on the camera display) or loads half-scaled \
> preview (otherwise) so it is fast, implementing was quite easy and theoretically it \
> enables gwenview to support everything dcraw supports (I haven't found a raw file \
> that gwenview doesn't show with this patch). The patch does not perform full \
> demosaicing nor any tweaks (set white balance or so) and I don't think it shall - \
> digikam, darktable or rawtherapee are much more suited for developing the 'digital \
> negatives'.
> The patch fixes BZ#158788
>
> The patch enables support for Nikon NEF and NRW formats, Canon's CR2 and CRW, \
> Pentax PEF, Sony ARW, Fuji RAF, Olympus ORF, Minolta MRW, Panasonic RW2, Samsung \
> SRW and Adobe DNG. If you want to try another format, just adding it's MIME type to \
> the list in lib/mimetypeutils.cpp shall be enough.
> The patch is feature-complete (generating proper thumbnails and viewing the raw \
> images incl. EXIF metadata) and well usable.
> There are some stuff to do (directory thumbnails and thumbnail in the file - \
> properties dialog in particular), but these things are out of gwenview sources. \
> I'll try to find out the proper place to place the fix (it seems that the \
> candidates are kdelibs, kipi plugins or digikam).
>
> Diffs
> -----
>
> lib/document/loadingdocumentimpl.cpp fbad8ff
> lib/CMakeLists.txt c6ffe14
> CMakeLists.txt 4dafb7e
> lib/gwenviewconfig.kcfg 231fd5e
> lib/mimetypeutils.cpp 546346f
> lib/thumbnailprovider/thumbnailgenerator.cpp 8b98904
>
> Diff: http://git.reviewboard.kde.org/r/113397/diff/
>
>
> Testing
> -------
>
> Tested on some sample raw files taken from the camera reviews on \
> http://www.photographyblog.com/ and bunch of my own photos. I have tried files of \
> every single format to be supported (for DNG I tested on files taken by cameras \
> from several vendors incl. Pentax, Leica and Nokia).
>
> Thanks,
>
> Martin Kyral
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113397/">http://git.reviewboard.kde.org/r/113397/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 14th, 2013, 4:27 p.m. CET, \
<b>Aurélien Gâteau</b> wrote:</p> <blockquote style="margin-left: 1em; \
border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: \
pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;">Looks good now, let's merge it in! Do you \
have an account on KDE git infrastructure?</pre> </blockquote>
<p>On November 14th, 2013, 4:30 p.m. CET, <b>Aurélien Gâteau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Regarding tests: I would \
like to have tests for raw files as well, but would rather avoid committing them to \
the git repository. What do you think of hosting a big archive of raw files on \
download.kde.org and enabling the tests only if the archive has been unpacked in the \
proper place?
Note: this can be done after your code is merged in.</pre>
</blockquote>
<p>On November 15th, 2013, 1:44 p.m. CET, <b>Martin Kyral</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Great! :) No, I \
don't have account on KDE git yet.
I like the idea with the archive of raw files on download.kde.org. However, I'll \
need to obtain some (I used mostly files downloaded from the \
http://www.photographyblog.com/ which is OK, but surely I don't have a permission \
of further distributing them). Of course, I'll provide some of my own photos \
(NEF, NRW). </pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Maybe we can reuse \
Digikam test images available from http://digikam3rdparty.free.fr/TEST_IMAGES/RAW/ ? \
One could write a shell script downloading a few of them with wget and then add a \
test to DocumentTest, with a QSKIP message suggesting to run the script if the raw \
images are not there.</pre> <br />
<p>- Aurélien</p>
<br />
<p>On November 19th, 2013, 10:22 a.m. CET, Martin Kyral wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Gwenview and Aurélien Gâteau.</div>
<div>By Martin Kyral.</div>
<p style="color: grey;"><i>Updated Nov. 19, 2013, 10:22 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
gwenview
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is a review of patch enabling raw support in gwenview. It uses \
KDcraw to extract the embedded jpeg preview (most of the raw formats contain it for \
the purposes of quick viewing the photos on the camera display) or loads half-scaled \
preview (otherwise) so it is fast, implementing was quite easy and theoretically it \
enables gwenview to support everything dcraw supports (I haven't found a raw file \
that gwenview doesn't show with this patch). The patch does not perform full \
demosaicing nor any tweaks (set white balance or so) and I don't think it shall - \
digikam, darktable or rawtherapee are much more suited for developing the \
'digital negatives'.
The patch fixes BZ#158788
The patch enables support for Nikon NEF and NRW formats, Canon's CR2 and CRW, \
Pentax PEF, Sony ARW, Fuji RAF, Olympus ORF, Minolta MRW, Panasonic RW2, Samsung SRW \
and Adobe DNG. If you want to try another format, just adding it's MIME type to \
the list in lib/mimetypeutils.cpp shall be enough.
The patch is feature-complete (generating proper thumbnails and viewing the raw \
images incl. EXIF metadata) and well usable.
There are some stuff to do (directory thumbnails and thumbnail in the file - \
properties dialog in particular), but these things are out of gwenview sources. \
I'll try to find out the proper place to place the fix (it seems that the \
candidates are kdelibs, kipi plugins or digikam).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested on some sample raw files taken from the camera reviews on \
http://www.photographyblog.com/ and bunch of my own photos. I have tried files of \
every single format to be supported (for DNG I tested on files taken by cameras from \
several vendors incl. Pentax, Leica and Nokia).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>lib/document/loadingdocumentimpl.cpp <span style="color: \
grey">(fbad8ff)</span></li>
<li>lib/CMakeLists.txt <span style="color: grey">(c6ffe14)</span></li>
<li>CMakeLists.txt <span style="color: grey">(4dafb7e)</span></li>
<li>lib/gwenviewconfig.kcfg <span style="color: grey">(231fd5e)</span></li>
<li>lib/mimetypeutils.cpp <span style="color: grey">(546346f)</span></li>
<li>lib/thumbnailprovider/thumbnailgenerator.cpp <span style="color: \
grey">(8b98904)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113397/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Gwenview-devel mailing list
Gwenview-devel@kde.org
https://mail.kde.org/mailman/listinfo/gwenview-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic