From gwenview-devel Thu Nov 07 08:34:31 2013 From: =?iso-8859-1?Q?Aur=E9lien_G=E2teau?= Date: Thu, 07 Nov 2013 08:34:31 +0000 To: gwenview-devel Subject: Re: Review Request 113397: RAW preview in gwenview Message-Id: <34540.109.13.158.252.1383813271.squirrel () webmail ! tuffmail ! net> X-MARC-Message: https://marc.info/?l=gwenview-devel&m=138381328124560 > > >> On Nov. 5, 2013, 5:04 p.m., Aur=C3=A9lien G=C3=A2teau wrote: >> > lib/thumbnailprovider/thumbnailgenerator.cpp, line 128 >> > >> > >> > It looks to me like the new code is never going to use the >> embedded thumbnail, this could have a bad impact on performance. > > Yep, it seems so. However, using the embedded small thumbnail has some > serious drawbacks: > > 1) there's no particular function in libraw (nor kdcraw), fetching the > small size thumbnail (unpack_thumb() returns the large preview if > present) > 2) not every raw file contains the small thumb > 3) the thumbnail (if any) is always 160x120 (4:3) while majority of > the raw-enabled cameras shoot 3:2 pictures. That leads to ugly > black stripes along the longer sides of the thumbnail. > 4) the thumbnail view shows the 160x120 as a resolution of the image > (not sure if this can be overriden by exif data and how) I was not speaking about raw files here. I am concerned about jpeg files. Embedded thumbnails are useful for jpeg files, Gwenview must use them if they are available. Aur=E9lien _______________________________________________ Gwenview-devel mailing list Gwenview-devel@kde.org https://mail.kde.org/mailman/listinfo/gwenview-devel