[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gump-commits
Subject:    svn commit: r980756 - /gump/trunk/python/gump/core/model/builder.py
From:       bodewig () apache ! org
Date:       2010-07-30 12:32:07
Message-ID: 20100730123207.E637B23889E9 () eris ! apache ! org
[Download RAW message or body]

Author: bodewig
Date: Fri Jul 30 12:32:07 2010
New Revision: 980756

URL: http://svn.apache.org/viewvc?rev=980756&view=rev
Log:
don't use version specified inside the POM if it contains property references

Modified:
    gump/trunk/python/gump/core/model/builder.py

Modified: gump/trunk/python/gump/core/model/builder.py
URL: http://svn.apache.org/viewvc/gump/trunk/python/gump/core/model/builder.py?rev=980756&r1=980755&r2=980756&view=diff
 ==============================================================================
--- gump/trunk/python/gump/core/model/builder.py (original)
+++ gump/trunk/python/gump/core/model/builder.py Fri Jul 30 12:32:07 2010
@@ -391,8 +391,14 @@ class Mvn2Install(Maven2):
                                      + " provide the version attribute")
                     return
                 version_text = getDomTextValue(version)
-                self._add_property(impl, Mvn2Install.VERSION,
-                                  version_text)
+                if '${' in version_text:
+                    project.addError("POM uses a property reference as version"
+                                     + " which is not supported by Gump.  You"
+                                     + " must provide an explicit version"
+                                     + " attribute to mvn2install.")
+                else:
+                    self._add_property(impl, Mvn2Install.VERSION,
+                                       version_text)
             except Exception, details:
                 project.addError('failed to parse POM because of '
                                  + str(details))


[prev in list] [next in list] [prev in thread] [next in thread]