[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gtk-devel
Subject:    Re: GLib may busy loop on invalid file descriptors
From:       Dan Winship <danw () gnome ! org>
Date:       2018-01-04 17:30:55
Message-ID: fdf272c5-0086-799c-2fe2-d21bddbc72ea () gnome ! org
[Download RAW message or body]

On 12/22/2017 06:09 AM, Benjamin Berg wrote:
> Hi,
> 
> I ran into an issue the other day where abrtd was polling an invalid
> file descriptor. Obviously, there must be a bug in abrtd which closed
> the wrong FD even though it was still registered with the mainloop
> using g_io_channel_unix_new and g_io_add_watch. However, the failure
> mode of GLib to simply busy loop seems quite bad.
> 
> Should g_io_unix_check maybe react to (G_IO_HUP | G_IO_ERR | G_IO_NVAL)
> in a way that results in an error and the removal of the source? That
> is, effectively run a fallback handler application is watching these
> error conditions.
> 
> A viable solution might be:
>  * Return TRUE from g_io_unix_check by always checking for the errors
>  * Test again in g_io_unix_dispatch but log an error and return FALSE
>    if none of the requested conditions match.
> 
> Thoughts?

FWIW I suggested more or less the same thing a long time ago but
eventually convinced myself was the wrong fix:
https://bugzilla.gnome.org/show_bug.cgi?id=321746

-- Dan

> Benjamin
> 
> PS: https://github.com/abrt/abrt/issues/1280 has some info on the
> specific issue.
> 
> 
> 
> _______________________________________________
> gtk-devel-list mailing list
> gtk-devel-list@gnome.org
> https://mail.gnome.org/mailman/listinfo/gtk-devel-list
> 
_______________________________________________
gtk-devel-list mailing list
gtk-devel-list@gnome.org
https://mail.gnome.org/mailman/listinfo/gtk-devel-list
[prev in list] [next in list] [prev in thread] [next in thread]