[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gtk-devel
Subject:    Bugs in gdkkeys-x11.c? (Was: gtk+ keynav screwed (at least on win32))
From:       Tor Lillqvist <tml () iki ! fi>
Date:       2002-02-26 23:10:16
[Download RAW message or body]

Isn't this code wrong:

 return XKeycodeToKeysym (gdk_display, key->keycode,
                          key->group * keysyms_per_keycode + key->level);

and
 tmp_keyval = XKeycodeToKeysym (gdk_display, hardware_keycode,
                                group * keysyms_per_keycode + shift_level);
Shouldn't that be 

 return XKeycodeToKeysym (gdk_display, key->keycode,
                          key->group * keysyms_per_keycode/2 + key->level);

and
 tmp_keyval = XKeycodeToKeysym (gdk_display, hardware_keycode,
                                group * keysyms_per_keycode/2 + shift_level);

(assuming there are two levels per group, as the code does in some
other places)

--tml

_______________________________________________
gtk-devel-list mailing list
gtk-devel-list@gnome.org
http://mail.gnome.org/mailman/listinfo/gtk-devel-list
[prev in list] [next in list] [prev in thread] [next in thread]