[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gstreamer-devel
Subject:    Re: [gst-devel] [gst-cvs] wtay gstreamer: gstreamer/
From:       Stefan Kost <ensonic () hora-obscura ! de>
Date:       2008-11-22 19:48:30
Message-ID: 4928620E.3050304 () hora-obscura ! de
[Download RAW message or body]

Wim Taymans schrieb:
> On Fri, 2008-11-21 at 23:40 +0200, Stefan Kost wrote:
> > hi,
> > 
> > wtay@kemper.freedesktop.org schrieb:
> > > CVS Root:       /cvs/gstreamer
> > > Module:         gstreamer
> > > Changes by:     wtay
> > > Date:           Fri Nov 21 2008  17:15:02 UTC
> > > 
> > > Log message:
> > > * libs/gst/base/gstbasetransform.c: (gst_base_transform_init),
> > > (gst_base_transform_getcaps), (gst_base_transform_find_transform),
> > > (gst_base_transform_acceptcaps), (gst_base_transform_getrange):
> > > Add beginnings of a more optimized acceptcaps function than the default
> > > core one.
> > > 
> > > Modified files:
> > > .               : ChangeLog
> > > libs/gst/base   : gstbasetransform.c
> > > 
> > > Links:
> > > http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.4169&r2=1.4170
> > >  http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/libs/gst/base/gstbasetransform.c.diff?r1=1.129&r2=1.130
> > >  
> > I get now plenty of
> > basetransform
> > gstbasetransform.c:1026:gst_base_transform_acceptcaps:<input_level_0x9108228>
> > transform could not transform audio/x-raw-float, width=(int)32, rate=(int)44100,
> > channels=(int)1, endianness=(int)1234 in anything we support
> > 
> > In gst_base_transform_acceptcaps(), should that be changed?
> > 
> > -othercaps = gst_pad_get_caps (pad);
> > +othercaps = gst_pad_get_caps (otherpad);
> 
> It should be 'pad' so it's fine, I reused the othercaps variable but
> I'll rename it to make the code clearer.
> 
> If you see that warning, it can only mean that an element has a
> capsnegotiation bug somewhere. A debug log could tell me more.

Despite the warning, everything works just fine. Here is a log with
GST_DEBUG="GST*:4" and GST_DEBUG="GST*:5"
http://www.buzztard.org/files/basetransform4.txt.gz
http://www.buzztard.org/files/basetransform5.txt.gz

But thanks for you recent optimization work, I see some good improvements in
buzztard already.

Stefan
> 
> Wim
> 
> 
> > 
> > Anyway in both cases othercaps is NULL.
> > 
> > Stefan
> > 
> > -------------------------------------------------------------------------
> > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> > Build the coolest Linux based applications with Moblin SDK & win great prizes
> > Grand prize is a trip for two to an Open Source event anywhere in the world
> > http://moblin-contest.org/redirect.php?banner_id=100&url=/
> > _______________________________________________
> > gstreamer-cvs mailing list
> > gstreamer-cvs@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/gstreamer-cvs
> 
> 
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> gstreamer-cvs mailing list
> gstreamer-cvs@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/gstreamer-cvs


-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
gstreamer-devel mailing list
gstreamer-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/gstreamer-devel


[prev in list] [next in list] [prev in thread] [next in thread]