[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gstreamer-cvs
Subject:    gst-plugins-base: tests: fix crashes in {audio, video}{decoder, encoder} tests on 32-bit
From:       tpm () kemper ! freedesktop ! org (Tim Müller)
Date:       2015-02-27 20:37:20
Message-ID: 20150227203720.A69A97633E () kemper ! freedesktop ! org
[Download RAW message or body]

Module: gst-plugins-base
Branch: master
Commit: 35bd289be36059d3abab632cebe766ec73974658
URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-base/commit/?id=35bd289be36059d3abab632cebe766ec73974658


Author: Tim-Philipp Müller <tim@centricular.com>
Date:   Fri Feb 27 20:22:59 2015 +0000

tests: fix crashes in {audio,video}{decoder,encoder} tests on 32-bit

Don't feed 64-bit integer variable into vararg function that expects
an unsigned integer to go with GST_TAG_TRACK_NUMBER. This would
cause crashes on 32-bit platforms, and if not that then test
failures if the comparisons fail later (at least on big endian
platforms).

---

 tests/check/libs/audiodecoder.c |    2 +-
 tests/check/libs/audioencoder.c |    2 +-
 tests/check/libs/videodecoder.c |    4 ++--
 tests/check/libs/videoencoder.c |    2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/tests/check/libs/audiodecoder.c b/tests/check/libs/audiodecoder.c
index b8cffda..bfcb333 100644
--- a/tests/check/libs/audiodecoder.c
+++ b/tests/check/libs/audiodecoder.c
@@ -448,7 +448,7 @@ _audiodecoder_flush_events (gboolean send_buffers)
 {
   GstSegment segment;
   GstBuffer *buffer;
-  guint64 i;
+  guint i;
   GList *events_iter;
   GstMessage *msg;
 
diff --git a/tests/check/libs/audioencoder.c b/tests/check/libs/audioencoder.c
index bd65341..2ca9520 100644
--- a/tests/check/libs/audioencoder.c
+++ b/tests/check/libs/audioencoder.c
@@ -283,7 +283,7 @@ GST_START_TEST (audioencoder_flush_events)
 {
   GstSegment segment;
   GstBuffer *buffer;
-  guint64 i;
+  guint i;
   GList *events_iter;
 
   setup_audioencodertester ();
diff --git a/tests/check/libs/videodecoder.c b/tests/check/libs/videodecoder.c
index 2197c75..bd3531f 100644
--- a/tests/check/libs/videodecoder.c
+++ b/tests/check/libs/videodecoder.c
@@ -344,7 +344,7 @@ GST_START_TEST (videodecoder_playback_with_events)
 {
   GstSegment segment;
   GstBuffer *buffer;
-  guint64 i;
+  guint i;
   GList *iter;
   GList *events_iter;
 
@@ -453,7 +453,7 @@ GST_START_TEST (videodecoder_flush_events)
 {
   GstSegment segment;
   GstBuffer *buffer;
-  guint64 i;
+  guint i;
   GList *events_iter;
 
   setup_videodecodertester (NULL, NULL);
diff --git a/tests/check/libs/videoencoder.c b/tests/check/libs/videoencoder.c
index e310f82..af7e06c 100644
--- a/tests/check/libs/videoencoder.c
+++ b/tests/check/libs/videoencoder.c
@@ -396,7 +396,7 @@ GST_START_TEST (videoencoder_flush_events)
 {
   GstSegment segment;
   GstBuffer *buffer;
-  guint64 i;
+  guint i;
   GList *events_iter;
 
   setup_videoencodertester ();


[Attachment #3 (text/plain)]

_______________________________________________
gstreamer-commits mailing list
gstreamer-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/gstreamer-commits


[prev in list] [next in list] [prev in thread] [next in thread]