[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gstreamer-cvs
Subject:    gst-plugins-bad: dvbsrc: drop FIXME on _ISDBT_LAYER_ENABLED prop
From:       reynaldo () kemper ! freedesktop ! org (Reynaldo H !  Verdejo Pinochet)
Date:       2014-08-29 23:43:46
Message-ID: 20140829234346.0582D761EF () kemper ! freedesktop ! org
[Download RAW message or body]

Module: gst-plugins-bad
Branch: master
Commit: a0c79bc72b4a3c230e0a20d1514222b483931840
URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/?id=a0c79bc72b4a3c230e0a20d1514222b483931840


Author: Reynaldo H. Verdejo Pinochet <reynaldo@osg.samsung.com>
Date:   Fri Aug 29 13:26:12 2014 -0400

dvbsrc: drop FIXME on _ISDBT_LAYER_ENABLED prop

Valid values range from 1 to 7 as stated.

DTV_ISDBT_LAYER_ENABLED bitmask is built from
OR-ing 0x1 0x2 0x4. If all bits are set
(0x00000111 = 7) it means all layers should be
demodulated.

---

 sys/dvb/gstdvbsrc.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/sys/dvb/gstdvbsrc.c b/sys/dvb/gstdvbsrc.c
index e297657..a7a3c55 100644
--- a/sys/dvb/gstdvbsrc.c
+++ b/sys/dvb/gstdvbsrc.c
@@ -741,8 +741,7 @@ gst_dvbsrc_class_init (GstDvbSrcClass * klass)
 
   /* Additional ISDB-T properties */
 
-  /* FIXME: bitmask, double check range, is 1 - 7, allowed
-     values are 0x1 0x2 0x3 |-ables */
+  /* Valid values are 0x1 0x2 0x4 |-ables */
   g_object_class_install_property (gobject_class,
       ARG_DVBSRC_ISDBT_LAYER_ENABLED,
       g_param_spec_uint ("isdbt-layer-enabled",

_______________________________________________
gstreamer-commits mailing list
gstreamer-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/gstreamer-commits


[prev in list] [next in list] [prev in thread] [next in thread]