[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gstreamer-cvs
Subject:    gst-plugins-base: audiodecoder: Fix broken boolean expression
From:       slomo () kemper ! freedesktop ! org (Sebastian Dröge)
Date:       2014-08-28 14:01:47
Message-ID: 20140828140147.1DB2F761F1 () kemper ! freedesktop ! org
[Download RAW message or body]

Module: gst-plugins-base
Branch: master
Commit: d357f282602776c7c3b1615ab360a7810edd054b
URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-base/commit/?id=d357f282602776c7c3b1615ab360a7810edd054b


Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Thu Aug 28 17:00:26 2014 +0300

audiodecoder: Fix broken boolean expression

We can seek with end_type==NONE and end_type==SET && end_position=-1. The
check for end_type!=NONE made the second condition impossible.

CID 1226439

---

 gst-libs/gst/audio/gstaudiodecoder.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gst-libs/gst/audio/gstaudiodecoder.c \
b/gst-libs/gst/audio/gstaudiodecoder.c index cada95b..654f21c 100644
--- a/gst-libs/gst/audio/gstaudiodecoder.c
+++ b/gst-libs/gst/audio/gstaudiodecoder.c
@@ -2183,7 +2183,7 @@ gst_audio_decoder_do_seek (GstAudioDecoder * dec, GstEvent * \
event)  return FALSE;
   }
 
-  if (end_type != GST_SEEK_TYPE_NONE ||
+  if ((end_type != GST_SEEK_TYPE_SET && end_type != GST_SEEK_TYPE_NONE) ||
       (end_type == GST_SEEK_TYPE_SET && end_time != GST_CLOCK_TIME_NONE)) {
     GST_DEBUG_OBJECT (dec, "unsupported seek: end time");
     return FALSE;



_______________________________________________
gstreamer-commits mailing list
gstreamer-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/gstreamer-commits


[prev in list] [next in list] [prev in thread] [next in thread]