[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gstreamer-cvs
Subject:    gst-plugins-good: mpegaudioparse: remove dead code
From:       vincent () kemper ! freedesktop ! org (Vincent Penquerc'h)
Date:       2014-04-30 17:15:59
Message-ID: 20140430171559.0EA4B761E5 () kemper ! freedesktop ! org
[Download RAW message or body]

Module: gst-plugins-good
Branch: master
Commit: 0253db6d36f076830dea140385ac9f7c87b8419c
URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit/?id=0253db6d36f076830dea140385ac9f7c87b8419c


Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Wed Apr 30 17:48:53 2014 +0100

mpegaudioparse: remove dead code

A stricer check is already done earlier, and integer overflows
do not seem possible here.

Coverity 1139675

---

 gst/audioparsers/gstmpegaudioparse.c |    7 -------
 1 file changed, 7 deletions(-)

diff --git a/gst/audioparsers/gstmpegaudioparse.c \
b/gst/audioparsers/gstmpegaudioparse.c index c1b2fd8..31bbc4c 100644
--- a/gst/audioparsers/gstmpegaudioparse.c
+++ b/gst/audioparsers/gstmpegaudioparse.c
@@ -1088,13 +1088,6 @@ gst_mpeg_audio_parse_handle_first_frame (GstMpegAudioParse * \
mp3parse,  goto out_vbri;
       }
 
-      if (avail < offset_vbri + 26) {
-        GST_DEBUG_OBJECT (mp3parse,
-            "Not enough data to read VBRI header (need %d)",
-            offset_vbri + 26 + nseek_points * seek_bytes);
-        goto cleanup;
-      }
-
       data = map.data;
       data += offset_vbri + 26;
 

_______________________________________________
gstreamer-commits mailing list
gstreamer-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/gstreamer-commits


[prev in list] [next in list] [prev in thread] [next in thread]