[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gstreamer-cvs
Subject:    gstreamer: scripts: improve git-update.sh status message
From:       tpm () kemper ! freedesktop ! org (Tim Müller)
Date:       2013-05-30 22:41:51
Message-ID: 20130530224151.5058176AB0 () kemper ! freedesktop ! org
[Download RAW message or body]

Module: gstreamer
Branch: master
Commit: 527423fcd9a5b74b8bc3dfbae75871b9c0f87f7c
URL:    http://cgit.freedesktop.org/gstreamer/gstreamer/commit/?id=527423fcd9a5b74b8bc3dfbae75871b9c0f87f7c


Author: Krzysztof Konopko <krzysztof.konopko@gmail.com>
Date:   Tue May 28 23:34:54 2013 +0100

scripts: improve git-update.sh status message

By default when the script is about to exit (normally or due to an error),
it checks whether $ERROR_LOG file exists.  If the log file exists, the
script prints a "Failures: " message prefix and dumps the log file to the
output.

Apparently the log file is always created and if the update/build is
successful, the script finishes with a bit misleading "Failures: " message.

An improvement provided with this change lets the log file to be created as
needed, i.e. if there's an error message to be printed.  If the file
doesn't exists, the script prints a "Update done" message which clearly
indicates success.

https://bugzilla.gnome.org/show_bug.cgi?id=701177

---

 scripts/git-update.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/scripts/git-update.sh b/scripts/git-update.sh
index 221e1ae..fba0c6e 100755
--- a/scripts/git-update.sh
+++ b/scripts/git-update.sh
@@ -28,7 +28,6 @@ tmp=$tmp/git-update.$(date \
+%Y%m%d-%H%M-).$RANDOM.$RANDOM.$RANDOM.$$  }
 
 ERROR_LOG="$tmp/failures.log"
-touch $ERROR_LOG
 ERROR_RETURN=255
 
 for m in $CORE $MODULES $EXTRA_MODULES; do
@@ -124,6 +123,7 @@ if test -e $ERROR_LOG;  then
   echo
   cat $ERROR_LOG
 else
+  echo "Update done"
   rm -rf "$tmp"
 fi
 exit

_______________________________________________
gstreamer-commits mailing list
gstreamer-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/gstreamer-commits


[prev in list] [next in list] [prev in thread] [next in thread]