[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gstreamer-cvs
Subject:    Re: [0.11] gst-plugins-base: audio: add function to build audio format
From:       Stefan Kost <ensonic () hora-obscura ! de>
Date:       2011-08-19 22:52:16
Message-ID: 4E4EE920.1020003 () hora-obscura ! de
[Download RAW message or body]

On 08/19/11 16:02, Wim Taymans wrote:
> Module: gst-plugins-base
> Branch: 0.11
> Commit: 7db6fa37b49858e517230181605961b7b04face1
> URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-base/commit/?id=7db6fa37b49858e517230181605961b7b04face1
>  
> Author: Wim Taymans <wim.taymans@collabora.co.uk>
> Date:   Fri Aug 19 16:00:33 2011 +0200
> 
> audio: add function to build audio format
> 
> ---
> 
> gst-libs/gst/audio/audio.c |   42 ++++++++++++++++++++++++++++++++++++++++++
> gst-libs/gst/audio/audio.h |   14 +++++++++-----
> 2 files changed, 51 insertions(+), 5 deletions(-)
> 
> diff --git a/gst-libs/gst/audio/audio.c b/gst-libs/gst/audio/audio.c
> index ea415c3..b04b9e4 100644
> --- a/gst-libs/gst/audio/audio.c
> +++ b/gst-libs/gst/audio/audio.c
> @@ -102,6 +102,48 @@ static GstAudioFormatInfo formats[] = {
> };
> 
> /**
> + * gst_audio_format_build_int:
> + * @sign: signed or unsigned format
> + * @endianness: G_LITTLE_ENDIAN or G_BIG_ENDIAN
> + * @width: amount of bits used per sample
> + * @depth: amount of used bits in @width
> + *
> + * Construct a #GstAudioFormat with given parameters.
> + *
> + * Returns: a #GstAudioFormat or GST_AUDIO_FORMAT_UNKNOWN when no audio format
> + * exists with the given parameters.
> + */
would gst_audio_format_get_{integer,float}_id() or
gst_audio_format_get_{integer,float}_format() be a better name? Spelling
'int' out would make it less ambigous (int=internal?) and avoids us even
considering 'flt' for float.

Stefan

_______________________________________________
gstreamer-commits mailing list
gstreamer-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/gstreamer-commits


[prev in list] [next in list] [prev in thread] [next in thread]