[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gstreamer-bugs
Subject:    [Bug 774811] vaapi: drm: cannot find render node in a hybrid graphics
From:       "GStreamer" (GNOME Bugzilla) <bugzilla () gnome ! org>
Date:       2016-11-30 16:32:48
Message-ID: bug-774811-6437-OzshJFmoKn () https ! bugzilla ! gnome ! org/
[Download RAW message or body]

https://bugzilla.gnome.org/show_bug.cgi?id=774811

Víctor Manuel Jáquez Leal <vjaquez@igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #341067|none                        |needs-work
             status|                            |

--- Comment #16 from Víctor Manuel Jáquez Leal <vjaquez@igalia.com> ---
Review of attachment 341067:
 --> (https://bugzilla.gnome.org/review?bug=774811&attachment=341067)

Thanks a lot!

Just a couple comments :)

::: gst-libs/gst/vaapi/gstvaapidisplay_drm.c
@@ +73,3 @@
+ */
+static gchar **
+vstrdupv (gchar *** paos, ...)

what about using GArray? It looks to me like the natural way to handle this.

@@ +298,3 @@
+        if (vaInitialize (va_dpy, &major_version,
+                &minor_version) == VA_STATUS_SUCCESS) {
+          vaTerminate (va_dpy);

here looks to me a memory leak, since the va_dpy is not vaTerminate if
vaInitialize fails, but still there's a context allocated

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
_______________________________________________
gstreamer-bugs mailing list
gstreamer-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/gstreamer-bugs

[prev in list] [next in list] [prev in thread] [next in thread]