[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gstreamer-bugs
Subject:    [Bug 775071] memory leak in usage of gst_pad_get_current_caps() API
From:       "GStreamer" (GNOME Bugzilla) <bugzilla () gnome ! org>
Date:       2016-11-30 8:03:24
Message-ID: bug-775071-6437-iBiQjHgpwg () https ! bugzilla ! gnome ! org/
[Download RAW message or body]

https://bugzilla.gnome.org/show_bug.cgi?id=775071

Sebastian Dröge (slomo) <slomo@coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #341020|none                        |needs-work
             status|                            |

--- Comment #7 from Sebastian Dröge (slomo) <slomo@coaxion.net> ---
Review of attachment 341020:
 --> (https://bugzilla.gnome.org/review?bug=775071&attachment=341020)

::: gst/rtp/gstrtpsbcdepay.c
@@ +179,3 @@
     /* Caps have changed, flush old data */
     gst_adapter_clear (depay->adapter);
+    gst_caps_unref (oldcaps);

You leak oldcaps if they are not NULL but can intersect with caps. Just put a
"if (oldcaps) gst_caps_unref (oldcaps)" after the whole if

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
_______________________________________________
gstreamer-bugs mailing list
gstreamer-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/gstreamer-bugs

[prev in list] [next in list] [prev in thread] [next in thread]