[prev in list] [next in list] [prev in thread] [next in thread] 

List:       grub-help
Subject:    Re: os-prober invalidates part of the menu management
From:       shawn wilson <ag4ve.us () gmail ! com>
Date:       2015-11-22 20:12:06
Message-ID: CAH_OBicPAiD6cOEqctG8ua7qVVWvSbe8WYfvfpJavuk6HFaeTg () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Nov 22, 2015 1:58 PM, "Arbiel (gmx)" <arbiel.perlacremaz@gmx.fr> wrote:
>

> Unfortunately, 30_os-prober generates the following code
> ---------------------------
> set timeout_style=menu
>  if [ "${timeout}" = 0 ]; then
>   set timeout=10
>  fi
> ---------------------------
>
> What is the purpose of this code, and shouldn't it be suppressed ?
>

I assume it's to set a sane default if nothing is set. However this might
be better done with:
[ -z "${timeout}" ]
Or maybe:
[ "${timeout}" = "" ]
(all untested)

Though, whatever change should use similar logic that are used for other
counters variables.

[Attachment #5 (text/html)]

<p dir="ltr"><br>
On Nov 22, 2015 1:58 PM, &quot;Arbiel (gmx)&quot; &lt;<a \
href="mailto:arbiel.perlacremaz@gmx.fr">arbiel.perlacremaz@gmx.fr</a>&gt; wrote:<br> \
&gt;</p> <p dir="ltr">&gt; Unfortunately, 30_os-prober generates the following \
code<br> &gt; ---------------------------<br>
&gt; set timeout_style=menu<br>
&gt;   if [ &quot;${timeout}&quot; = 0 ]; then<br>
&gt;    set timeout=10<br>
&gt;   fi<br>
&gt; ---------------------------<br>
&gt;<br>
&gt; What is the purpose of this code, and shouldn&#39;t it be suppressed ?<br>
&gt;</p>
<p dir="ltr">I assume it&#39;s to set a sane default if nothing is set. However this \
might be better done with:<br> [ -z &quot;${timeout}&quot; ] <br>
Or maybe:<br>
[ &quot;${timeout}&quot; = &quot;&quot; ] <br>
(all untested) </p>
<p dir="ltr">Though, whatever change should use similar logic that are used for other \
counters variables. </p>



_______________________________________________
Help-grub mailing list
Help-grub@gnu.org
https://lists.gnu.org/mailman/listinfo/help-grub


[prev in list] [next in list] [prev in thread] [next in thread]