[prev in list] [next in list] [prev in thread] [next in thread] 

List:       grub-devel
Subject:    Re: Re: [PATCH v2] net: fix null pointer dereference when parsing ICMP6_ROUTER_ADVERTISE messages
From:       Daniel Kiper <dkiper () net-space ! pl>
Date:       2022-04-21 17:39:07
Message-ID: 20220421173907.ovrd4b3hukf7nbkh () tomti ! i ! net-space ! pl
[Download RAW message or body]

On Thu, Apr 21, 2022 at 01:56:35PM +0000, zhangqiumiao via Grub-devel wrote:
> On Thu, Apr 21, 2022 at 21:41:52PM +0800, Daniel Kiper wrote:
> > On Sat, Apr 16, 2022 at 09:50:11AM +0800, Qiumiao Zhang via Grub-devel wrote:
> > > During UEFI PXE boot in IPv6 network, if the DHCP server adopts
> > > stateful automatic configuration, then the client receives a
> > > ICMP6_ROUTER_ADVERTISE multicast message from the server. This may be
> > > received without the interfaced having a configured network address,
> > > so orig_inf will be null, which can lead to a null dereference when
> > > creating the default route. Actually, in this case, the client obtains
> > > the default route through DHCPv6 instead of RA messages. So if
> > > orig_inf == NULL and route_inf == null, we should not set the default
> > > route.
> > >
> > > Fixes bug: https://savannah.gnu.org/bugs/index.php?62072
>
> > Missing "Signed-off-by: Qiumiao Zhang <zhangqiumiao1@huawei.com>" line.
> > May I add it on behalf of you?
>
> Yes, that's perfect.

Cool! Thank you for fixing this!

Daniel

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

[prev in list] [next in list] [prev in thread] [next in thread]