[prev in list] [next in list] [prev in thread] [next in thread] 

List:       grub-devel
Subject:    Re: [PATCH 11/17] cryptodisk: Rename total_length field in grub_cryptodisk_t to total_sectors.
From:       Glenn Washburn <development () efficientek ! com>
Date:       2020-07-30 21:58:46
Message-ID: 20200730165846.527d5b66 () crass-HP-ZBook-15-G2
[Download RAW message or body]

On Thu, 30 Jul 2020 17:29:58 +0200
Patrick Steinhardt <ps@pks.im> wrote:

> On Wed, Jul 29, 2020 at 04:50:16PM -0500, development@efficientek.com
> wrote:
> > From: Glenn Washburn <development@efficientek.com>
> > 
> > This makes the creates an alignment with grub_disk_t naming of the
> > same field and is more intuitive as to how it should be used.
> > 
> > Signed-off-by: Glenn Washburn <development@efficientek.com>

...

> > --- a/grub-core/disk/luks.c
> > +++ b/grub-core/disk/luks.c
> > @@ -113,7 +113,7 @@ configure_ciphers (grub_disk_t disk, const char
> > *check_uuid, newdev->offset = grub_be_to_cpu32
> > (header.payloadOffset); newdev->source_disk = NULL;
> >    newdev->log_sector_size = LOG_SECTOR_SIZE;
> > -  newdev->total_length = grub_disk_get_size (disk) -
> > newdev->offset;
> > +  newdev->total_sectors = grub_disk_get_size (disk) -
> > newdev->offset;
> 
> Oh, yes please. Care to add in another patch that does the same for
> offset? `offset_sectors` would also be much clearer to me.

Yep, I'll add an extra patch for that in the next patch set.


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

[prev in list] [next in list] [prev in thread] [next in thread]