[prev in list] [next in list] [prev in thread] [next in thread] 

List:       grub-devel
Subject:    Re: [PATCH v3 1/6] efi: add central copy of grub_efi_find_mmap_size
From:       Leif Lindholm <leif.lindholm () linaro ! org>
Date:       2018-07-06 16:21:17
Message-ID: 20180706162117.xljs52leaozqq3km () bivouac ! eciton ! net
[Download RAW message or body]

On Fri, Jul 06, 2018 at 05:00:45PM +0200, Daniel Kiper wrote:
> On Wed, Jun 27, 2018 at 06:17:15PM +0100, Leif Lindholm wrote:
> > There are several implementations of this function in the tree.
> > Add a central version in grub-core/efi/mm.c.
> 
> I am happy with the code itself but I am not sure why you are
> not replacing these "several implementations of this function"
> in the existing code. I would like to see a patch which does that.

I am happy to submit further cleanup patches once this set gets in,
but this is a fundamental change in behaviour compared to those other
bits of code (which I do not exercise or use). It is also a
fundamental change in behaviour compared to the previous version
submitted. I feel a temporary duplication minimises risk of further
disruption.

Best Regards,

Leif

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
[prev in list] [next in list] [prev in thread] [next in thread]