[prev in list] [next in list] [prev in thread] [next in thread] 

List:       grub-devel
Subject:    Re: [PATCH] Better ahci error handling
From:       Daniel Kiper <dkiper () net-space ! pl>
Date:       2018-01-08 12:40:30
Message-ID: 20180108124030.GA21935 () router-fw-old ! local ! net-space ! pl
[Download RAW message or body]

On Wed, Jan 03, 2018 at 11:36:29AM +0100, Stefan Fritsch wrote:
> On Tue, 2 Jan 2018, Michel Hermier wrote:
>
> > Hi,
> > IS_FATAL_ERROR sounds like a utility macro, I would add a parameter to test
> > the flags and make it return a Bool compatible value.
> > My 2 cents comments.
> > Cheers
>
> Yes, the IS_FATAL_ERROR name is not good. I have renamed it to
> GRUB_AHCI_HBA_PORT_IS_FATAL_MASK.

May I ask you to repost the patch with suggested fixes with your SOB and CC me?

Daniel

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
[prev in list] [next in list] [prev in thread] [next in thread]