[prev in list] [next in list] [prev in thread] [next in thread] 

List:       grub-devel
Subject:    Re: [PATCH] efinet: retransmit if our device is busy
From:       Josef Bacik <jbacik () fb ! com>
Date:       2015-09-11 19:08:29
Message-ID: 55F326AD.1000509 () fb ! com
[Download RAW message or body]

On 09/11/2015 12:49 PM, Andrei Borzenkov wrote:
> 31.08.2015 20:34, Josef Bacik пишет:
>> When I fixed the txbuf handling I ripped out the retransmission code
>> since it
>> was flooding our network when we had the buggy behavior.  Turns out
>> this was too
>> heavy handed as we can still have transient tx timeouts.  So instead
>> make sure
>> we retry our transmission once per timeout.  This way we can deal with
>> transient
>> transmission problems without flooding the box.  This fixes an issue
>> we were
>> seeing in production.  Thanks,
>>
>
> You mean you get timeout in efi send_card_buffer, not higher level? That
> sounds like something steals completion status. Could you send lsefi
> after network interface was opened?

No i get a timeout at a higher level.  We try to transmit, we never get 
the txbuf thing from getstatus, and we never redo the transmit.  This 
just adds the retransmit back in.  Thanks,

Josef


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

[prev in list] [next in list] [prev in thread] [next in thread]