[prev in list] [next in list] [prev in thread] [next in thread] 

List:       grub-devel
Subject:    Re: [PATCH] Fix a special case when accessing partition on linux
From:       Bruce Dubbs <bruce.dubbs () gmail ! com>
Date:       2010-01-31 20:22:50
Message-ID: 4B65E69A.4010106 () gmail ! com
[Download RAW message or body]

Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> Because of cache coherency problem grub accesses partitions on linux by
> hdaX device and not by hda with correct offset. The problem is that
> because of 4K cache blocks disk.c may read sectors before the partition
> and hence making hostdisk.c try to read from negative offset. I'm sad
> that we need such workarounds for free systems.

I would think it beneficial for long term code maintenance to put
the above comments into the code itself.

// Because of a cache coherency problem grub accesses partitions
// on linux by an hdaX device and not by hda with the correct offset.
// The problem is that because of 4K cache blocks, disk.c may
// read sectors before the partition and hence make
// hostdisk.c try to read from a  negative offset.

   -- Bruce



[prev in list] [next in list] [prev in thread] [next in thread]