[prev in list] [next in list] [prev in thread] [next in thread] 

List:       grub-devel
Subject:    RE: grub fails to tftp a file with more than 64K blocks
From:       "Guzovsky, Eduard" <eguzovsk () enterasys ! com>
Date:       2004-04-15 15:22:31
Message-ID: C28780ABC637504896EB86B4FB75FFBF98C0D8 () MAANDMBX1 ! ets ! enterasys ! com
[Download RAW message or body]

Thanks. I did not realize the bug-grub mailing list is for the patches.
I'll follow the rules next time.

-Ed


-----Original Message-----
From: grub-devel-bounces+eguzovsk=enterasys.com@gnu.org
[mailto:grub-devel-bounces+eguzovsk=enterasys.com@gnu.org] On Behalf Of
Yoshinori K. Okuji
Sent: Thursday, April 15, 2004 7:37 AM
To: The development of GRUB 2
Subject: Re: grub fails to tftp a file with more than 64K blocks

On Wednesday 14 April 2004 04:39, Guzovsky, Eduard wrote:
> Grub version 0.94 with (or without) "grub-0[1].94-diskless-1.patch"
> fails to tftp a file with more than 64K blocks. Bellow is a fix. Note
> that the bug exists in buf_fill() function.

Thanks for your contribution, but this is not the right place to send 
your patch. grub-devel is used for GRUB 2 but not for GRUB legacy. 
bug-grub is used for patches against GRUB legacy instead.

This time, I accept your patch here, but please use bug-grub rather than

grub-devel from now on.

Also, I'd like you to read the instructions on how to send patches in 
the manual. It should say that:

1. Unified format is desirable as a diff format.
2. Reverse patches are not good.
3. You should write a ChangeLog entry for your change.

Okuji



_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/grub-devel





[prev in list] [next in list] [prev in thread] [next in thread]