[prev in list] [next in list] [prev in thread] [next in thread]
List: groovy-scm
Subject: [groovy-scm] [jira] (GROOVY-5898) Sql.java throws IllegalStateException("Failed to process query. Un
From: "Paul King (JIRA)" <jira () codehaus ! org>
Date: 2013-06-30 3:58:03
Message-ID: JIRA.143340.1357836587211.8372.1372564683404 () codehaus01 ! managed ! contegix ! com
[Download RAW message or body]
<style>
/* Changing the layout to use less space for mobiles */
@media screen and (max-device-width: 480px), screen and \
(-webkit-min-device-pixel-ratio: 2) { #email-body { min-width: 30em !important; }
#email-page { padding: 8px !important; }
#email-banner { padding: 8px 8px 0 8px !important; }
#email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; }
#email-fields { padding: 0 8px 8px 8px !important; }
#email-gutter { width: 0 !important; }
}
</style>
<div id="email-body">
<table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" \
style="background-color:#f0f0f0;color:#000000;width:100%;"> <tr valign="top">
<td id="email-page" style="padding:16px !important;">
<table align="center" border="0" cellpadding="0" cellspacing="0" \
style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;"> \
<tr valign="top"> <td bgcolor="#ffffff" \
style="background-color:#ffffff;color:#00AA00;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img \
src="http://www.codehaus.org/codehaus-small.gif" alt="" style="vertical-align:top;" \
/></td> </tr><tr valign="top">
<td id="email-banner" style="padding:32px 32px 0 32px;">
<table align="left" border="0" cellpadding="0" cellspacing="0" \
width="100%" style="width:100%;"> <tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;">
<img id="email-avatar" \
src="https://jira.codehaus.org/secure/useravatar?ownerId=paulk&avatarId=10910" alt="" \
height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px \
0;" />
<div id="email-action" style="padding: 0 0 8px \
0;font-size:12px;line-height:18px;"> <a class="user-hover" rel="paulk" \
id="email_paulk" href="https://jira.codehaus.org/secure/ViewProfile.jspa?name=paulk" \
style="color:#005500;">Paul King</a> updated <img \
src="https://jira.codehaus.org/images/icons/issuetypes/bug.png" height="16" \
width="16" border="0" align="absmiddle" alt="Bug"> <a \
style='color:#005500;text-decoration:none;' \
href='https://jira.codehaus.org/browse/GROOVY-5898'>GROOVY-5898</a> </div>
<div id="email-summary" \
style="font-size:16px;line-height:20px;padding:2px 0 16px 0;"> <a \
style='color:#005500;text-decoration:none;' \
href='https://jira.codehaus.org/browse/GROOVY-5898'><strong>Sql.java throws \
IllegalStateException("Failed to process query. Unterminated ' \
character?") when comments contain quotes</strong></a> </div>
</td>
</tr>
</table>
</td>
</tr>
<tr valign="top">
<td id="email-fields" style="padding:0 32px 32px 32px;">
<table border="0" cellpadding="0" cellspacing="0" \
style="padding:0;text-align:left;width:100%;" width="100%"> <tr valign="top">
<td id="email-gutter" style="width:64px;white-space:nowrap;"></td>
<td>
<table border="0" cellpadding="0" cellspacing="0" width="100%">
<tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 \
10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Change By:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 \
0 10px 0;width:100%;"> <a class="user-hover" rel="paulk" id="email_paulk" \
href="https://jira.codehaus.org/secure/ViewProfile.jspa?name=paulk" \
style="color:#005500;">Paul King</a> (29/Jun/13 10:56 PM)
</td>
</tr>
<tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 \
10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Description:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 \
0 10px 0;width:100%;"> <span \
class="diffcontext">In versions of Groovy since 1.8, whe \
n Groovy SQL prepares to execute a parameterized&nb \
sp;query, it checks the query SQL for unterminated& \
nbsp;single quotes (lines 4168 - 4188 of groovy.sql \
.Sql.java in the current trunk source). However, th \
e current code doesn't recognize that when the& \
nbsp;SQL contains comments, and the comments include&nbs \
p;apostrophes or single quote characters, that the \
SQL is valid.<br><br>For example, this code will result in an exception:<br></span>
<span class="diffaddedchars" style="background-color:#ddfade;">{code}</span>
<span class="diffcontext"><br>def myQuery = """<br>  \
; select count(*), cast(? as varchar(10))<br> --&n \
bsp;An ' apostrophe<br> from art.option <br>"& \
quot;"<br><br>sql.eachRow(myQuery.toString(), ['1.7.5']) <br>{row -><br> println row<br>}<br></span>
<span class="diffaddedchars" style="background-color:#ddfade;">{code}</span>
<span class="diffcontext"><br></span>
<span class="diffaddedchars" style="background-color:#ddfade;"><br></span>
<span class="diffcontext">Perhaps you could use a regex \
or string replace to remove or ignore everything&nb \
sp;found between "--" and "\n" or &q \
uot;/*" and "*/" before testing for unterminated quotes?</span>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td><!-- End #email-page -->
</tr>
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: \
0 16px 16px 16px;text-align:center;"> This message is automatically generated by \
JIRA.<br />
If you think it was sent incorrectly, please contact your JIRA \
administrators<br />
For more information on JIRA, see: <a style='color:#005500;' \
href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a>
</td>
</tr>
</table><!-- End #email-wrap -->
</div><!-- End #email-body -->
<hr/>
<p>
To unsubscribe from this list please visit:
</p>
<p>
<a href="http://xircles.codehaus.org/manage_email">http://xircles.codehaus.org/manage_email</a>
</p>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic