[prev in list] [next in list] [prev in thread] [next in thread] 

List:       groovy-dev
Subject:    Re: [groovy-dev] ClassNodes and line numbers for error messages
From:       "Martin C. Martin" <martin () martincmartin ! com>
Date:       2009-01-28 14:16:08
Message-ID: 498068A8.4030903 () martincmartin ! com
[Download RAW message or body]

Great; thanks for the clarification.

Best,
Martin

Jochen Theodorou wrote:
> Martin C. Martin schrieb:
>> Hi all,
>>
>> So ClassNodes for primitive types are cached, meaning wherever the 
>> keyword "double" appears in a groovy source, the ASTNode for it is 
>> always ClassHelper.double_TYPE.  So the line & column numbers are 
>> always -1.
>>
>> Does this cause any problems for error messages?  Or is that 
>> information stored somewhere else I'm not seeing?  Or is it never 
>> needed for error messages?
> 
> well in what cases do we report errors on the ClassNode itself? Normally 
> only if the ClassNode could not be resolved, or if there is some problem 
> with inheritance. In these case there can't be a primitive type. Also it 
> has to be something that is reported after AntlrParserPlugin (APP), 
> because the grammar and the plugin itself do catch a lot of errors already.
> 
> for example  "List<int> foo" is catched in APP...
> 
> So till now there was never a need for it. But it shoulnd't really be a 
> problem to use the same redirection mechanism we already have.
> 
> bye blackdrag
> 

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


[prev in list] [next in list] [prev in thread] [next in thread]