[prev in list] [next in list] [prev in thread] [next in thread] 

List:       grid-engine-dev
Subject:    Some commlib_v1.0 issues
From:       John Marshall <John.Marshall () ec ! gc ! ca>
Date:       2004-01-20 23:26:34
Message-ID: 1074641194.1484.87.camel () mango ! cmc ! ec ! gc ! ca
[Download RAW message or body]

Hi,

I found some items in the commlib_v1.0
package which need to be taken care of
for SUPER-UX:

1) libs/commlib_v1.0/test_cl_hostname_list.c

   <netinet/in.h> needs to be included for
   'struct in_addr'

   If it is decided to #include the
   <netinet/in.h> in
   libs/commlib_v1.0/cl_data_types.h
   then this problem will disappear.

   Recall that I brought this issue up
   for libs/commlib_v1.0/cl_tcp_framework.h
   earlier.

   My diff to patch the cl_data_types.h
   file is:

-----
Index: gridengine/source/libs/commlib_v1.0/cl_data_types.h
===================================================================
RCS file: /cvs/gridengine/source/libs/commlib_v1.0/cl_data_types.h,v
retrieving revision 1.1
diff -u -p -r1.1 cl_data_types.h
--- gridengine/source/libs/commlib_v1.0/cl_data_types.h 13 Jan 2004 09:57:42 -0000      1.1
+++ gridengine/source/libs/commlib_v1.0/cl_data_types.h 20 Jan 2004 23:19:51 -0000
@@ -37,6 +37,9 @@
 */
 #include <sys/param.h>
 #include <netdb.h>
+#if defined(NECSX4) || defined(NECSX5)
+#include <netinet/in.h>
+#endif
 #include "cl_lists.h"
-----

2) libs/commlib_v1.0/cl_tcp_framework.c

   socklen_t does not exist under SUPER-UX.
   The type to use is 'int'.

   My diff to patch the cl_tcp_framework.c
   file is:
-----
Index: gridengine/source/libs/commlib_v1.0/cl_tcp_framework.c
===================================================================
RCS file: /cvs/gridengine/source/libs/commlib_v1.0/cl_tcp_framework.c,v
retrieving revision 1.2
diff -u -p -r1.2 cl_tcp_framework.c
--- gridengine/source/libs/commlib_v1.0/cl_tcp_framework.c      20 Jan 2004 17:39:07 -0000      1.2
+++ gridengine/source/libs/commlib_v1.0/cl_tcp_framework.c      20 Jan 2004 23:21:13 -0000
@@ -291,7 +291,7 @@ int cl_com_tcp_open_connection(cl_com_co
    #endif
                if (select_back > 0) {
                   int socket_error;
-#if defined(SOLARIS) && !defined(SOLARIS64)
+#if (defined(SOLARIS) && !defined(SOLARIS64)) || defined(NECSX4) || defined(NECSX5)
                   int socklen = sizeof(socket_error);
 #else
                   socklen_t socklen = sizeof(socket_error);
-----

Any comments?

Thanks,
John


[prev in list] [next in list] [prev in thread] [next in thread]