[prev in list] [next in list] [prev in thread] [next in thread] 

List:       grid-engine-cvs
Subject:    CVS update: MODIFIED: util ...
From:       dom () sunsource ! net
Date:       2004-11-24 16:19:57
Message-ID: 20041124161957.12351.qmail () s005 ! sfo ! collab ! net
[Download RAW message or body]

  User: dom     
  Date: 04/11/24 08:19:57

  Modified:    source/dist/util arch arch.dist
  Added:       review   MD-2004-11-24-0.txt
  Log:
  MD-2004-11-24-0: Bugfix:    arch script does not know about /lib64
                   Review:    JG
                   Changed:   arch, arch.dist
                   Issue:     1357
                   Bugtraq:   6200013
  
  Revision  Changes    Path
  1.2404    +6 -0      gridengine/Changelog
  
  http://gridengine.sunsource.net/source/browse/gridengine/Changelog.diff?r1=1.2403&r2=1.2404
  
  (In the diff below, changes in quantity of whitespace are not shown.)
  
  Index: Changelog
  ===================================================================
  RCS file: /cvs/gridengine/Changelog,v
  retrieving revision 1.2403
  retrieving revision 1.2404
  diff -u -b -r1.2403 -r1.2404
  --- Changelog	2004/11/24 15:45:35	1.2403
  +++ Changelog	2004/11/24 16:19:54	1.2404
  @@ -1,3 +1,9 @@
  +MD-2004-11-24-0: Bugfix:    arch script does not know about /lib64
  +                 Review:    JG
  +                 Changed:   arch, arch.dist
  +                 Issue:     1357
  +                 Bugtraq:   6200013
  +
   JG-2004-11-24-0: Bugfix:    sge_qmaster hit stack limit on aix43, aix51 and hp11
                               with classic spooling.
                    Review:    CR
  
  
  
  1.1                  gridengine/review/MD-2004-11-24-0.txt
  
  http://gridengine.sunsource.net/source/browse/gridengine/review/MD-2004-11-24-0.txt?rev=1.1&content-type=text/x-cvsweb-markup
  
  Index: MD-2004-11-24-0.txt
  ===================================================================
  Source Code Review Form 
  =======================
  (version 1.1)
  
  Date: 2004-11-24
  
  1 Identification
  
  1.1 Issue         : 1357
  1.2 Bugtraq       : 6200013        
  1.3 Summary       : arch script does not know about /lib64
  1.4 Changelog ID  : MD-2004-11-24-0
  1.5 Developer(s)  : MD
  1.6 Reviewer(s)   : JG        
  
  
  2 Conformance to specification
  
  2 [x ] yes
  2 [ ] no - comment:
  
  
  3 Documentation
  
  3.1 user/admin guide
  3.1 [x ] yes
  3.1 [ ] no - comment:
  
  3.2 man pages (user view)
  3.2 [x ] yes
  3.2 [ ] no - comment:
  
  3.3 -help output
  3.3 [x ] yes
  3.3 [ ] no - comment:
  
  3.4 documented interfaces (at least GDI, EVI, libs)
  3.4 [x ] yes
  3.4 [ ] no - comment:
  
  3.5 messages, output formats
  3.5 [x ] yes
  3.5 [ ] no - comment:
  
  
  4 Source review
  
  4.1 Style guide conformance
  4.1 [x ] yes
  4.1 [ ] no - comment:
  
  4.2 Memory leaks
  4.2 [x ] yes
  4.2 [ ] no - comment:
  
  4.3 Thread safe
  4.3 [x ] yes
  4.3 [ ] no
  
  
  5 Tests
  
  5.1 flawfinder diff
  No new flaws.
  5.1 [x ] yes
  5.1 [ ] no: 
  
  5.2 Used memory leak debugger
  5.2 [x ] yes
  5.2 [ ] no - comment:
  
  5.3 Manual tests
  Description:
  Successfull execution
  5.3 [x ] yes
  5.3 [ ] no - comment:
  
  5.4 Testsuite covers issue
  5.4 [ ] yes
  5.4 [x ] no - comment: no test
  
  5.5 If 5.4 = no: Testsuite issue created
  5.5 [ ] yes
  5.5 [x ] no - comment: no time
  
  5.6 Testsuite run successfull
  5.6 [x ] yes
  5.6 [ ] no - comment:
  
  
  6 Comments
  
  
  7 Accepted
  7 [x ] yes
  7 [ ] no - comment:
  
  
  
  
  
  1.23      +8 -1      gridengine/source/dist/util/arch
  
  http://gridengine.sunsource.net/source/browse/gridengine/source/dist/util/arch.diff?r1=1.22&r2=1.23
  
  (In the diff below, changes in quantity of whitespace are not shown.)
  
  Index: arch
  ===================================================================
  RCS file: /cvs/gridengine/source/dist/util/arch,v
  retrieving revision 1.22
  retrieving revision 1.23
  diff -u -b -r1.22 -r1.23
  --- arch	2004/10/12 16:19:54	1.22
  +++ arch	2004/11/24 16:19:56	1.23
  @@ -181,7 +181,14 @@
         lxrelease=22
         ;;
      2.4.*)
  +      case $lxmachine in
  +      amd64)
  +        strings /lib64/libc.so.6 | grep "GNU C Library" | grep "2\.0" 2>&1 > \
/dev/null  +        ;;
  +      *)
         strings /lib/libc.so.6 | grep "GNU C Library" | grep "2\.0" 2>&1 > /dev/null
  +      esac
  +
         if [ $? = 0 ]; then
            lxrelease=UNSUPPORTED-linux2.2-glibc2.0
         else
  
  
  
  1.4       +8 -1      gridengine/source/dist/util/arch.dist
  
  http://gridengine.sunsource.net/source/browse/gridengine/source/dist/util/arch.dist.diff?r1=1.3&r2=1.4
  
  (In the diff below, changes in quantity of whitespace are not shown.)
  
  Index: arch.dist
  ===================================================================
  RCS file: /cvs/gridengine/source/dist/util/arch.dist,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -b -r1.3 -r1.4
  --- arch.dist	2004/11/15 10:47:45	1.3
  +++ arch.dist	2004/11/24 16:19:57	1.4
  @@ -172,7 +172,14 @@
         lxrelease=22
         ;;
      2.[46].*)
  +      case $lxmachine in
  +      amd64)
  +        strings /lib64/libc.so.6 | grep "GNU C Library" | grep "2\.0" 2>&1 > \
/dev/null  +        ;;
  +      *)
         strings /lib/libc.so.6 | grep "GNU C Library" | grep "2\.0" 2>&1 > /dev/null
  +      esac
  +
         if [ $? = 0 ]; then
            lxrelease=UNSUPPORTED-linux2.2-glibc2.0
         else
  
  
  


[prev in list] [next in list] [prev in thread] [next in thread]