[prev in list] [next in list] [prev in thread] [next in thread] 

List:       grid-engine-cvs
Subject:    CVS update: MODIFIED: uti ...
From:       ernst () sunsource ! net
Date:       2004-06-22 11:56:37
Message-ID: 20040622115637.14052.qmail () s005 ! sfo ! collab ! net
[Download RAW message or body]

  User: ernst   
  Date: 04/06/22 04:56:36

  Modified:    source/libs/uti sge_string.c
  Log:
  EB-2004-06-22-0: Cleanup:   Added ADOC commets
  
  Revision  Changes    Path
  1.2102    +8 -4      gridengine/Changelog
  
  http://gridengine.sunsource.net/source/browse/gridengine/Changelog.diff?r1=1.2101&r2=1.2102
  
  (In the diff below, changes in quantity of whitespace are not shown.)
  
  Index: Changelog
  ===================================================================
  RCS file: /cvs/gridengine/Changelog,v
  retrieving revision 1.2101
  retrieving revision 1.2102
  diff -u -b -r1.2101 -r1.2102
  --- Changelog	2004/06/18 11:44:48	1.2101
  +++ Changelog	2004/06/22 11:56:32	1.2102
  @@ -1,9 +1,13 @@
  -CR-2004-06-18-1: Testsuite: - new check for CR-2004-06-18-0 ( issues 1096 and \
1098)  +EB-2004-06-22-0: Cleanup:   Added ADOC commets
  +
  +CR-2004-06-18-1: Testsuite: - new check for CR-2004-06-18-0 (issues 1096 and 
  +                              1098)
                               - new configuration parameter: reserved_port
  -                            - fixed testsuite problem on shutdown of multi \
                threaded 
  -                              qmaster process(es!) on linux systems.
  +                            - fixed testsuite problem on shutdown of multi 
  +                              threaded qmaster process(es!) on linux systems.
   
  -CR-2004-06-18-0: Bugfix:    o sge_qmaster will not start unless run only as "root"
  +CR-2004-06-18-0: Bugfix:    o sge_qmaster will not start unless run only as 
  +                              "root"
                               o qmaster cannot bind port below 1024 on Linux
                    Changed:   qmaster
                    Issue:     1096, 1098
  
  
  
  1.38      +2 -1      gridengine/source/libs/cull/cull_multitype.c
  
  http://gridengine.sunsource.net/source/browse/gridengine/source/libs/cull/cull_multitype.c.diff?r1=1.37&r2=1.38
  
  (In the diff below, changes in quantity of whitespace are not shown.)
  
  Index: cull_multitype.c
  ===================================================================
  RCS file: /cvs/gridengine/source/libs/cull/cull_multitype.c,v
  retrieving revision 1.37
  retrieving revision 1.38
  diff -u -b -r1.37 -r1.38
  --- cull_multitype.c	2004/05/24 12:52:13	1.37
  +++ cull_multitype.c	2004/06/22 11:56:34	1.38
  @@ -1060,7 +1060,8 @@
   *  RESULT
   *     lList* - CULL list pointer 
   ******************************************************************************/
  -lList *lGetList(const lListElem *ep, int name) 
  +lList *
  +lGetList(const lListElem *ep, int name) 
   {
      int pos;
      DENTER(CULL_BASIS_LAYER, "lGetList");
  
  
  
  1.9       +57 -3     gridengine/source/libs/sgeobj/sge_ja_task.c
  
  http://gridengine.sunsource.net/source/browse/gridengine/source/libs/sgeobj/sge_ja_task.c.diff?r1=1.8&r2=1.9
  
  (In the diff below, changes in quantity of whitespace are not shown.)
  
  Index: sge_ja_task.c
  ===================================================================
  RCS file: /cvs/gridengine/source/libs/sgeobj/sge_ja_task.c,v
  retrieving revision 1.8
  retrieving revision 1.9
  diff -u -b -r1.8 -r1.9
  --- sge_ja_task.c	2004/03/19 14:54:58	1.8
  +++ sge_ja_task.c	2004/06/22 11:56:34	1.9
  @@ -376,8 +376,36 @@
      return ret;
   }
   
  -/* EB: ADOC: add commets */
  -
  +/****** sgeobj/ja_task/ja_task_message_add() **********************************
  +*  NAME
  +*     ja_task_message_add() -- add a message to the message list of a task 
  +*
  +*  SYNOPSIS
  +*     bool 
  +*     ja_task_message_add(lListElem *this_elem, u_long32 type, 
  +*                         const char *message) 
  +*
  +*  FUNCTION
  +*     Adds a message in the "JAT_message_list"-message list of "this_elem"
  +*     "type" will be the message type. "message" is the text string stored
  +*     int the new element of the sublist.  
  +*
  +*  INPUTS
  +*     lListElem *this_elem - JAT_Type element 
  +*     u_long32 type        - message type id 
  +*     const char *message  - message 
  +*
  +*  RESULT
  +*     bool - error state
  +*        true  - success
  +*        false - error 
  +*
  +*  NOTES
  +*     MT-NOTE: ja_task_message_add() is MT safe 
  +*
  +*  SEE ALSO
  +*     sgeobj/ja_task/ja_task_message_trash_all_of_type_X()
  +*******************************************************************************/
   bool
   ja_task_message_add(lListElem *this_elem, u_long32 type, const char *message)
   {
  @@ -389,6 +417,32 @@
      return ret;
   }
   
  +/****** sgeobj/ja_task/ja_task_message_trash_all_of_type_X() ******************
  +*  NAME
  +*     ja_task_message_trash_all_of_type_X() -- Trash messages of certain type 
  +*
  +*  SYNOPSIS
  +*     bool 
  +*     ja_task_message_trash_all_of_type_X(lListElem *this_elem, 
  +*                                         u_long32 type) 
  +*
  +*  FUNCTION
  +*     Trash all messages from the sublist of JAT_message_list which are of
  +*     the given "type". 
  +*     
  +*
  +*  INPUTS
  +*     lListElem *this_elem - JAT_Type element 
  +*     u_long32 type        - type id 
  +*
  +*  RESULT
  +*     bool - error state
  +*        true  - success
  +*        false - error 
  +*
  +*  NOTES
  +*     MT-NOTE: ja_task_message_trash_all_of_type_X() is MT safe 
  +*******************************************************************************/
   bool
   ja_task_message_trash_all_of_type_X(lListElem *this_elem, u_long32 type)
   {
  
  
  
  1.33      +26 -4     gridengine/source/libs/sgeobj/sge_job.c
  
  http://gridengine.sunsource.net/source/browse/gridengine/source/libs/sgeobj/sge_job.c.diff?r1=1.32&r2=1.33
  
  (In the diff below, changes in quantity of whitespace are not shown.)
  
  Index: sge_job.c
  ===================================================================
  RCS file: /cvs/gridengine/source/libs/sgeobj/sge_job.c,v
  retrieving revision 1.32
  retrieving revision 1.33
  diff -u -b -r1.32 -r1.33
  --- sge_job.c	2004/04/15 15:50:49	1.32
  +++ sge_job.c	2004/06/22 11:56:35	1.33
  @@ -1704,7 +1704,7 @@
   *
   *     Please note: The "*_O_*" env variables get their final
   *                  name shortly before job execution. Find more 
  -*                  information in the ADOC comment of
  +*                  information in the comment of
   *                  job_initialize_env()
   *
   *  INPUTS
  @@ -1742,7 +1742,7 @@
   *
   *     Please note: The "*_O_*" env variables get their final
   *                  name shortly before job execution. Find more 
  -*                  information in the ADOC comment of
  +*                  information in the comment of
   *                  job_initialize_env()
   *
   *  INPUTS
  @@ -2470,8 +2470,28 @@
         return STATUS_OK;
   }
   
  -/* EB: ADOC: add commets */
  -
  +/****** sgeobj/job/job_get_request() ******************************************
  +*  NAME
  +*     job_get_request() -- Returns the requested centry name 
  +*
  +*  SYNOPSIS
  +*     lListElem * 
  +*     job_get_request(const lListElem *this_elem, const char **centry_name) 
  +*
  +*  FUNCTION
  +*     Returns the requested centry name if it is requested by the give
  +*     job (JB_Type). 
  +*
  +*  INPUTS
  +*     const lListElem *this_elem - JB_Type element 
  +*     const char *centry_name    - name 
  +*
  +*  RESULT
  +*     lListElem * - CE_Type element
  +*
  +*  NOTES
  +*     MT-NOTE: job_get_request() is MT safe 
  +*******************************************************************************/
   lListElem *
   job_get_request(const lListElem *this_elem, const char *centry_name) 
   {
  @@ -2489,6 +2509,8 @@
      DEXIT;
      return ret;
   }
  +
  +/* EB: ADOC: add commets */
   
   bool
   job_get_contribution(const lListElem *this_elem, lList **answer_list,
  
  
  
  1.58      +19 -1     gridengine/source/libs/sgeobj/sge_object.c
  
  http://gridengine.sunsource.net/source/browse/gridengine/source/libs/sgeobj/sge_object.c.diff?r1=1.57&r2=1.58
  
  (In the diff below, changes in quantity of whitespace are not shown.)
  
  Index: sge_object.c
  ===================================================================
  RCS file: /cvs/gridengine/source/libs/sgeobj/sge_object.c,v
  retrieving revision 1.57
  retrieving revision 1.58
  diff -u -b -r1.57 -r1.58
  --- sge_object.c	2004/05/24 16:28:09	1.57
  +++ sge_object.c	2004/06/22 11:56:35	1.58
  @@ -1108,7 +1108,25 @@
      return ret;
   }
   
  -/* EB: ADOC: add commets */
  +/****** sgeobj/object/object_name_get_type() **********************************
  +*  NAME
  +*     object_name_get_type() -- Return type id of a certain object 
  +*
  +*  SYNOPSIS
  +*     sge_object_type object_name_get_type(const char *name) 
  +*
  +*  FUNCTION
  +*     returns the type id a an object given by "name" 
  +*
  +*  INPUTS
  +*     const char *name - object name 
  +*
  +*  RESULT
  +*     sge_object_type - type of the object
  +*
  +*  NOTES
  +*     MT-NOTE: object_name_get_type() is MT safe 
  +*******************************************************************************/
   sge_object_type object_name_get_type(const char *name)
   {
      sge_object_type ret = SGE_TYPE_ALL;
  
  
  
  1.12      +37 -19    gridengine/source/libs/sgeobj/sge_qinstance_state.c
  
  http://gridengine.sunsource.net/source/browse/gridengine/source/libs/sgeobj/sge_qinstance_state.c.diff?r1=1.11&r2=1.12
  
  (In the diff below, changes in quantity of whitespace are not shown.)
  
  Index: sge_qinstance_state.c
  ===================================================================
  RCS file: /cvs/gridengine/source/libs/sgeobj/sge_qinstance_state.c,v
  retrieving revision 1.11
  retrieving revision 1.12
  diff -u -b -r1.11 -r1.12
  --- sge_qinstance_state.c	2004/02/13 03:49:37	1.11
  +++ sge_qinstance_state.c	2004/06/22 11:56:35	1.12
  @@ -187,9 +187,7 @@
      lSetUlong(this_elem, QU_state, state);
   }
   
  -
  -
  -/****** sge_qinstance_state/qinstance_has_state() ******************************
  +/****** sgeobj/qinstance_state/qinstance_has_state() **************************
   *  NAME
   *     qinstance_has_state() -- checks a qi for a given states 
   *
  @@ -213,11 +211,38 @@
   *
   *******************************************************************************/
   bool qinstance_has_state(const lListElem *this_elem, u_long32 bit) {
  -   if (bit == U_LONG32_MAX)
  -      return true;
  +   bool ret = true;
  +
  +   if (bit != U_LONG32_MAX) {
      return (lGetUlong(this_elem, QU_state) & bit) ? true : false;
  +   }
   }
   
  +/****** sgeobj/qinstance_state/transition_is_valid_for_qinstance() ************
  +*  NAME
  +*     transition_is_valid_for_qinstance() -- is transition valid 
  +*
  +*  SYNOPSIS
  +*     bool 
  +*     transition_is_valid_for_qinstance(u_long32 transition, 
  +*                                       lList **answer_list) 
  +*
  +*  FUNCTION
  +*     Checks if the given transition is valid for a qinstance object.
  +*     If the transition is valid, than true will be returned by this function. 
  +*
  +*  INPUTS
  +*     u_long32 transition - transition id 
  +*     lList **answer_list - AN_Type list 
  +*
  +*  RESULT
  +*     bool - test result
  +*        true  - transition is valid
  +*        false - transition is invalid
  +*
  +*  NOTES
  +*     MT-NOTE: transition_is_valid_for_qinstance() is MT safe 
  +*******************************************************************************/
   bool
   transition_is_valid_for_qinstance(u_long32 transition, lList **answer_list)
   {
  @@ -252,6 +277,7 @@
      return ret;
   }
   
  +/* EB: What is the purpose of this function? */
   bool
   transition_option_is_valid_for_qinstance(u_long32 option, lList **answer_list)
   {
  @@ -302,11 +328,6 @@
          * if something is changed here
          */
   
  -      /*
  -       * Don't forget to change the names-array, too
  -       * if something is changed here
  -       */
  -
         0 
      };
      static const char *names[23] = { NULL }; 
  @@ -343,7 +364,6 @@
      while (states[i] != 0) {
         if (states[i] == bit) {
            ret = names[i];
  -         DTRACE;
            break;
         }
         i++;
  @@ -352,8 +372,7 @@
      return ret;
   }
   
  -
  -/****** sge_qinstance_state/qinstance_state_from_string() **********************
  +/****** sgeobj/qinstance_state/qinstance_state_from_string() ******************
   *  NAME
   *     qinstance_state_from_string() -- takes a state string and returns an int 
   *
  @@ -372,14 +391,13 @@
   *  RESULT
   *     u_long32 - new state or 0, if no state was set
   *
  -*  EXAMPLE
  -*     ??? 
  -*
   *  NOTES
   *     MT-NOTE: qinstance_state_from_string() is MT safe 
  -*
   *******************************************************************************/
  -u_long32 qinstance_state_from_string(const char* sstate, lList **answer_list, \
u_long32 filter){  +u_long32 
  +qinstance_state_from_string(const char* sstate, 
  +                            lList **answer_list, 
  +                            u_long32 filter){
      u_long32 ustate = 0;
      int i;
      int y;
  
  
  
  1.20      +41 -5     gridengine/source/libs/uti/sge_string.c
  
  http://gridengine.sunsource.net/source/browse/gridengine/source/libs/uti/sge_string.c.diff?r1=1.19&r2=1.20
  
  (In the diff below, changes in quantity of whitespace are not shown.)
  
  Index: sge_string.c
  ===================================================================
  RCS file: /cvs/gridengine/source/libs/uti/sge_string.c,v
  retrieving revision 1.19
  retrieving revision 1.20
  diff -u -b -r1.19 -r1.20
  --- sge_string.c	2004/04/20 15:29:12	1.19
  +++ sge_string.c	2004/06/22 11:56:36	1.20
  @@ -472,11 +472,29 @@
      return;
   }
   
  -/* EB: ADOC: add commets */
  -
  +/****** uti/string/sge_strip_white_space_at_eol() ******************************
  +*  NAME
  +*     sge_strip_white_space_at_eol() -- truncate white space at EOL 
  +*
  +*  SYNOPSIS
  +*     void sge_strip_white_space_at_eol(char *str) 
  +*
  +*  FUNCTION
  +*     Truncate white space from the end of the string 
  +*
  +*  INPUTS
  +*     char *str - string to be modified 
  +*
  +*  RESULT
  +*     void - NONE
  +*
  +*  NOTES
  +*     MT-NOTE: sge_strip_white_space_at_eol() is MT safe 
  +*******************************************************************************/
   void sge_strip_white_space_at_eol(char *str) 
   {
      DENTER(BASIS_LAYER, "sge_strip_white_space_at_eol");
  +
      if (str != NULL) {
         size_t length = strlen(str);
   
  @@ -1179,9 +1197,27 @@
      return ret;
   }
   
  -
  -/* EB: ADOC: add commets */
  -
  +/****** uti/string/sge_str_is_number() *****************************************
  +*  NAME
  +*     sge_str_is_number() -- represents the given string a number 
  +*
  +*  SYNOPSIS
  +*     bool sge_str_is_number(const char *string) 
  +*
  +*  FUNCTION
  +*     This function returns true if the given string represents a number. 
  +*
  +*  INPUTS
  +*     const char *string - string 
  +*
  +*  RESULT
  +*     bool - result
  +*        true  - string represents a number
  +*        false - string is not a number 
  +*
  +*  NOTES
  +*     MT-NOTE: sge_str_is_number() is MT safe 
  +*******************************************************************************/
   bool sge_str_is_number(const char *string)
   {
      char *end = NULL;
  
  
  


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic