[prev in list] [next in list] [prev in thread] [next in thread]
List: grass-qa
Subject: [GRASS-QA] GRASS QA: martinl |main.c main.c | no clones | 0
From: soccerlab.info () gmail ! com
Date: 2010-06-03 15:38:27
Message-ID: 14422981.251275579499886.JavaMail.tomcat () web ! soccerlab ! polymtl ! ca
[Download RAW message or body]
Hello martinl,
here's a report on your recent grass-SVN change for the revision : 42467
ANALYSIS
your changes to files/class/methods/functions :
*****************************************************************
File :/db/db.select/main.c
*****************************************************************
Function
parse_command_line(Begins at: 179, Ends at:298)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 8 | | OK | 8 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 52 | ** | BABY-MONSTER | 52 |
LOC: | 120 | * | WARNING | 120 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/db/db.execute/main.c
*****************************************************************
Function
parse_command_line(Begins at: 97, Ends at:146)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 26 | * | WARNING | 26 |
LOC: | 50 | | OK | 50 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
____________________________________________
Threshold grass key metrics values at Thu Jun 03 11:38:19 EDT 2010 are:
----------------------+-----------+-----------+-----------+
| warning | middle | extrem |
| limits | limits | limits |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo): | 11 | 24 | 38 |
ParamNBR: | 3 | 6 | 9 |
CalledNBR: | 21 | 49 | 78 |
LOC: | 80 | 183 | 287 |
----------------------+-----------+-----------+-----------+
Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)
Message interpretation :
OK : Nothing to say at all
* : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function
Conclusion interpretation :
CORRECT : if all metrics are situated before warning limits
WARNING : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS : if 1 to more metrics are in the extreme limits
_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
Please visite our web site on your project at :
http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html
_______________________________________________
grass-qa mailing list
grass-qa@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-qa
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic