[prev in list] [next in list] [prev in thread] [next in thread] 

List:       graphviz-devel
Subject:    [graphviz-devel] Re: Probable cut&paste error
From:       "Emden R. Gansner" <erg () research ! att ! com>
Date:       2010-06-10 17:02:03
Message-ID: 4C111A8B.20009 () research ! att ! com
[Download RAW message or body]

Philipp Thomas wrote:
> lib/sfio/sfhdr.h has 
>
> #define _SFOPEN(f)	((f)->mode == SF_READ  ? _SFOPENRD(f) : \
> 			 (f)->mode == SF_WRITE ? _SFOPENWR(f) : \
> 			 ((f)->endr = (f)->endr = (f)->data) )
>
> And the compiler rightly complains for the last line that the operation on
> (f)->endr may be undefined. Am I guessing right that this should be
>
> #define _SFOPEN(f)	((f)->mode == SF_READ  ? _SFOPENRD(f) : \
> 			 (f)->mode == SF_WRITE ? _SFOPENWR(f) : \
> 			 ((f)->endr = (f)->endw = (f)->data) )
>
> ?
>
>   

Yes, though officially, it is

			 ((f)->endw = (f)->endr = (f)->data) )

:)

Thanks for pointing this out. I have fixed the source.

    Emden



_______________________________________________
graphviz-devel mailing list
graphviz-devel@research.att.com
https://mailman.research.att.com/mailman/listinfo/graphviz-devel
[prev in list] [next in list] [prev in thread] [next in thread]