[prev in list] [next in list] [prev in thread] [next in thread] 

List:       graphicsmagick-commit
Subject:    [GM-commit] GraphicsMagick: OpenBlob() should not rewind
From:       GraphicsMagick Commits <graphicsmagick-commit () lists ! sourceforge ! net>
Date:       2011-11-27 21:03:59
Message-ID: hg.9502aaaf8c04.1322427839.-1602079902 () blade ! simplesystems ! org
[Download RAW message or body]

changeset 9502aaaf8c04 in /hg/GraphicsMagick
details: http://hg.GraphicsMagick.org/hg/GraphicsMagick?cmd=changeset;node=9502aaaf8c04
                
summary: OpenBlob() should not rewind user-provided file handle

diffstat:

 ChangeLog          |  6 ++++++
 magick/blob.c      |  1 -
 www/Changelog.html |  5 +++++
 3 files changed, 11 insertions(+), 1 deletions(-)

diffs (41 lines):

diff -r 2112dc8add28 -r 9502aaaf8c04 ChangeLog
--- a/ChangeLog	Sun Nov 27 14:48:50 2011 -0600
+++ b/ChangeLog	Sun Nov 27 15:03:54 2011 -0600
@@ -1,5 +1,11 @@
 2011-11-27  Bob Friesenhahn  <bfriesen@simple.dallas.tx.us>
 
+	* magick/blob.c (OpenBlob): Don't rewind already open file handle
+	passed to OpenBlob() since we don't know the intended state of
+	this file handle, and because it prevents appending to an existing
+	file.  This change is part of the fix for SourceForge issue
+	3046868 "added MagickWriteImagesFile".
+
 	* wand/magick_wand.c (MagickSetImageSavedType): New function to
 	allow specifying the storage type used when saving the file
 	(rather than changing the current image characteristics).
diff -r 2112dc8add28 -r 9502aaaf8c04 magick/blob.c
--- a/magick/blob.c	Sun Nov 27 14:48:50 2011 -0600
+++ b/magick/blob.c	Sun Nov 27 15:03:54 2011 -0600
@@ -2563,7 +2563,6 @@
                 image->blob->file=image_info->file;
                 image->blob->type=FileStream;
                 image->blob->exempt=True;
-                (void) rewind(image->blob->file);
                 if (image->logging)
                   (void) LogMagickEvent(BlobEvent,GetMagickModule(),
                                         "  opened image_info->file (%d) as \
                FileStream blob 0x%p",
diff -r 2112dc8add28 -r 9502aaaf8c04 www/Changelog.html
--- a/www/Changelog.html	Sun Nov 27 14:48:50 2011 -0600
+++ b/www/Changelog.html	Sun Nov 27 15:03:54 2011 -0600
@@ -39,6 +39,11 @@
 <p>2011-11-27  Bob Friesenhahn  &lt;<a class="reference external" \
href="mailto:bfriesen&#37;&#52;&#48;simple&#46;dallas&#46;tx&#46;us">bfriesen<span>&#6 \
4;</span>simple<span>&#46;</span>dallas<span>&#46;</span>tx<span>&#46;</span>us</a>&gt;</p>
  <blockquote>
 <ul class="simple">
+<li>magick/blob.c (OpenBlob): Don't rewind already open file handle
+passed to OpenBlob() since we don't know the intended state of
+this file handle, and because it prevents appending to an existing
+file.  This change is part of the fix for SourceForge issue
+3046868 &quot;added MagickWriteImagesFile&quot;.</li>
 <li>wand/magick_wand.c (MagickSetImageSavedType): New function to
 allow specifying the storage type used when saving the file
 (rather than changing the current image characteristics).

------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure 
contains a definitive record of customers, application performance, 
security threats, fraudulent activity, and more. Splunk takes this 
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
_______________________________________________
Graphicsmagick-commit mailing list
Graphicsmagick-commit@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/graphicsmagick-commit


[prev in list] [next in list] [prev in thread] [next in thread]