[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gpsd-dev
Subject:    Re: [gpsd-dev] [PATCH 1/2] Moves Linux-only ppscheck program back to contrib/.
From:       Fred Wright <fw () fwright ! net>
Date:       2016-08-10 22:23:59
Message-ID: Pine.LNX.4.58L1X.1608101518020.18725 () bolt ! sonic ! net
[Download RAW message or body]


On Wed, 10 Aug 2016, Robert Norris wrote:

> AFAIK scons cleans/builds all the programs it knows about.
>
> However in the gpsd SConstruct there are code paths for 'cleaning' and
> 'building', so both paths must generate the same list of programs so
> they can be built or cleaned.

Generally speaking, yes, but the configure stuff is sufficiently slow and
verbose that it's mostly bypassed in the "cleaning or helping" cases.

> Thus I believe the pps (and so also the kpps) tests need to be before
> the "if cleaning or helping:" line 617, but after the variable config is
> made available.

It's much simpler to fix than that.  There's no problem *cleaning*
ppscheck on any platform.  Patch coming.

Fred Wright

[prev in list] [next in list] [prev in thread] [next in thread]