[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gpsd-dev
Subject:    Re: [gpsd-dev] BUZZKILL_ENABLE needed
From:       "Eric S. Raymond" <esr () thyrsus ! com>
Date:       2015-01-27 0:45:52
Message-ID: 20150127004552.GA21426 () thyrsus ! com
[Download RAW message or body]

Jon Schlueter <jon.schlueter@gmail.com>:
> If you are going that route it might be just as useful to move the
> buzzkill_enable/disable flag into the configuration block instead of a
> global and adjust as needed.

If you mean the global context, Reinhard alreadyt submitted an amended
patch that does that.

 
Reinhard.Arlt@t-online.de <Reinhard.Arlt@t-online.de> wrote:
 > Hello,
>
> i do not like the configuration BUZZKILL_ENABLE option too.
>
> Please have a look at the attached patch, i think, it can make it too.
>
> Setting source_type to source_pty overwrite source_can, so i removed it.
> With this patch,
> it is not necessary.
>
> And
>
> gpsd:ERROR: PPS ioctl(TIOCMIWAIT) failed: 22 Invalid argument
>
> is there again. I do not understand, why ppsd still fire up.
>
> Reinhard

Because it doesn't know that shouldn't be done for source_can.  I'll fix it.
-- 
		<a href="http://www.catb.org/~esr/">Eric S. Raymond</a>

[prev in list] [next in list] [prev in thread] [next in thread]