[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gnutls-dev
Subject:    Re: _gnutls_hostname_compare: toupper vs. c_toupper
From:       Simon Josefsson <simon () josefsson ! org>
Date:       2011-05-20 20:48:04
Message-ID: 87pqndm73v.fsf () latte ! josefsson ! org
[Download RAW message or body]

Nikos Mavrogiannopoulos <nmav@gnutls.org> writes:

> On 05/03/2011 10:53 PM, Kalle Olavi Niemitalo wrote:
>> In GnuTLS 2.8.6 and 2.10.5, _gnutls_hostname_compare uses toupper
>> on the characters of the hostname:
>> 
>>   /* find the first different character */
>>   for (; *certname && *hostname && toupper (*certname) == toupper (*hostname);
>>        certname++, hostname++, certnamesize--)
>>     ;
>> I suspect this should be c_toupper instead, so that 'i' matches
>> 'I' in hostnames even in a Turkish (or is that Turkic?) locale.
>
> You're right. This however makes it apparent that
> gnutls_x509_crt_check_hostname() does not really support
> internationalized DNS names...

I think that is intentional -- it is IDN unaware domain name slot, and
hence should only contain a ASCII domain.

/Simon

_______________________________________________
Gnutls-devel mailing list
Gnutls-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/gnutls-devel
[prev in list] [next in list] [prev in thread] [next in thread]