[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gnulib-bug
Subject:    Re: [PATCH] ignore-value: remove deprecated ignore_ptr function
From:       Jim Meyering <jim () meyering ! net>
Date:       2012-05-14 15:34:10
Message-ID: 87pqa6g4jx.fsf () rho ! meyering ! net
[Download RAW message or body]

Bruno Haible wrote:

> Jim Meyering wrote on 2012-01-10:
>> We deprecated ignore_ptr a year ago:
>>
>>   http://thread.gmane.org/gmane.linux.utilities.util-linux-ng/3784/focus=3802
>>
>> So I've removed it.
>> ...
>> +2012-01-10  Jim Meyering  <meyering@redhat.com>
>> +
>> +	ignore-value: remove deprecated ignore_ptr function
>> +	* lib/ignore-value.h (ignore_ptr): Remove deprecated function.
>> +	* NEWS: Note this.
>
> The _GL_ATTRIBUTE_DEPRECATED definition in lib/ignore-value.h is now unused.
> You can remove it as well.

Thanks!

From d0f24fdec899e6533de47012efb0e7a56d984ead Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Mon, 14 May 2012 17:33:15 +0200
Subject: [PATCH] ignore-value.h: remove unused _GL_ATTRIBUTE_DEPRECATED
 definition

* lib/ignore-value.h (_GL_ATTRIBUTE_DEPRECATED): Remove now-unused
definition.  Reported by Bruno Haible.
---
 ChangeLog          |  6 ++++++
 lib/ignore-value.h | 10 ----------
 2 files changed, 6 insertions(+), 10 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index b7f143b..c45ec1a 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2012-05-14  Jim Meyering  <meyering@redhat.com>
+
+	ignore-value.h: remove unused _GL_ATTRIBUTE_DEPRECATED definition
+	* lib/ignore-value.h (_GL_ATTRIBUTE_DEPRECATED): Remove now-unused
+	definition.  Reported by Bruno Haible.
+
 2012-05-13  Bruno Haible  <bruno@clisp.org>
 	    Paul Eggert  <eggert@cs.ucla.edu>

diff --git a/lib/ignore-value.h b/lib/ignore-value.h
index 52919de..2e34435 100644
--- a/lib/ignore-value.h
+++ b/lib/ignore-value.h
@@ -35,16 +35,6 @@
 #ifndef _GL_IGNORE_VALUE_H
 # define _GL_IGNORE_VALUE_H

-# ifndef _GL_ATTRIBUTE_DEPRECATED
-/* The __attribute__((__deprecated__)) feature
-   is available in gcc versions 3.1 and newer.  */
-#  if __GNUC__ < 3 || (__GNUC__ == 3 && __GNUC_MINOR__ < 1)
-#   define _GL_ATTRIBUTE_DEPRECATED /* empty */
-#  else
-#   define _GL_ATTRIBUTE_DEPRECATED __attribute__ ((__deprecated__))
-#  endif
-# endif
-
 /* The __attribute__((__warn_unused_result__)) feature
    is available in gcc versions 3.4 and newer,
    while the typeof feature has been available since 2.7 at least.  */
--
1.7.10.2.484.gcd07cc5

[prev in list] [next in list] [prev in thread] [next in thread]