[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gnulib-bug
Subject:    Re: [PATCH] mmap-anon.m4: do not use regex in AC_EGREP_CPP
From:       Eric Blake <eblake () redhat ! com>
Date:       2011-06-28 12:35:55
Message-ID: 4E09CAAB.4040102 () redhat ! com
[Download RAW message or body]


On 06/28/2011 05:14 AM, Paolo Bonzini wrote:
> grep restricts its use of grep to things that are effectively fixed
> strings, in order to remove a recursive dependency on a "good" grep that
> supports arbitrarily long lines.  However, mmap-anon.m4 has one such
> instance.  This patch, suggested by Rainer Orth, removes "special"
> characters from the string being sought.
> 
> Ok?
> 
> Paolo
> 
> 2011-06-27  Paolo Bonzini  <bonzini@gnu.org>
> 
>     * m4/mmap-anon.m4: Do not use special characters in the
>     regular expression.

Makes sense to me.  Go for it!

-- 
Eric Blake   eblake@redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]