[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gnulib-bug
Subject:    Re: [Patch] Add dirent.d_type support to Cygwin 1.7 ?
From:       "James Youngman" <jay () gnu ! org>
Date:       2008-11-30 23:21:04
Message-ID: c5df85930811301521t484caf93sc74e4ee2fed7a13 () mail ! gmail ! com
[Download RAW message or body]

On Sat, Nov 29, 2008 at 3:53 PM, James Youngman <jay@gnu.org> wrote:
> On Sat, Nov 29, 2008 at 3:46 PM, Jim Meyering <jim@meyering.net> wrote:
>> Jim Meyering <jim@meyering.net> wrote:
>>> "James Youngman" <jay@gnu.org> wrote:
>>>> As far as I can see, the variable type is assigned in the function
>>>> above, but never used.   Did you mean to use "type" rather than
>>>> "dtype" in the expression which assigns to st->st_mode?
>>>
>>> Thanks again.
>>> Here's the patch I'll push as soon as you say ok:
>>
>> I hadn't tested enough after all.
>> That didn't work either.  But this does.
>> With *it*, all 1133 of find's tests really do pass:
>
> Looks good to me, though I did no local testing.
>
> I will apply your find patch at some point this weekend, I hope.

I've applied the patch to the CVS trunk for findutils; it will appear
in findutils 4.5.3, whenever that is released.

Thanks!

James.



[prev in list] [next in list] [prev in thread] [next in thread]