[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gnulib-bug
Subject:    Re: fts.c doesn't compile with C89 compiler
From:       Jim Meyering <jim () meyering ! net>
Date:       2006-10-25 13:18:22
Message-ID: 87iri8wn35.fsf () rho ! meyering ! net
[Download RAW message or body]

Jim Meyering <jim@meyering.net> wrote:
> Bruno Haible <bruno@clisp.org> wrote:
...
>> fts.c:1076: warning: ISO C90 forbids mixed declarations and code
>>
>> gnulib still assumes C89 only. Here is a fix.
>>
>> Jim, OK to apply?
>
> That looks fine.
> Yes, thanks.

Thanks for checking it in.
However, I was surprised to see that your commit log message
was something very brief and not descriptive, like "ANSI C!",
nowhere near as useful as the ChangeLog entry:

	* lib/fts.c (fts_build): Move variable declaration, for C89 compliance.

I've changed the log message.

I have found that it is useful to keep the commit log message
very similar to the ChangeLog entry.



[prev in list] [next in list] [prev in thread] [next in thread]