[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gnulib-bug
Subject:    Re: one more warning in argp-help
From:       Eric Blake <ebb9 () byu ! net>
Date:       2005-12-10 22:22:52
Message-ID: 439B553C.4070301 () byu ! net
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Jim Meyering on 12/10/2005 3:19 PM:
> Removing trailing blanks is a worthy goal, but it is better never to
> mix white-space-only changes and any other type of change.  The white-
> space-only hunks make it hard to find the significant part of the patch.

Resend, with no whitespace differences (I know that diff -b sometimes
messes up indenting, but in this case, it worked).

2005-12-10  Eric Blake  <ebb9@byu.net>

	* argp-help.c (__argp_failure) [USE_IN_LIBIO || _LIBC ||
	HAV_DECL_STRERROR_R]: Only declare buf when used, to avoid
	compiler warning.

- --
Life is short - so eat dessert first!

Eric Blake             ebb9@byu.net
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFDm1U884KuGfSFAYARApFsAJ9jbD/dnmY9XqCrN8Wi/+NONqf2UQCgs1Am
BBQtFly+1yLUWJKRAJiDWm4=
=THjV
-----END PGP SIGNATURE-----

["gnulib.patch5" (text/plain)]

Index: lib/argp-help.c
===================================================================
RCS file: /cvsroot/gnulib/gnulib/lib/argp-help.c,v
retrieving revision 1.20
diff -u -p -b -r1.20 argp-help.c
--- lib/argp-help.c	10 Dec 2005 21:37:29 -0000	1.20
+++ lib/argp-help.c	10 Dec 2005 22:21:42 -0000
@@ -1892,7 +1892,9 @@ __argp_failure (const struct argp_state 
 
 	  if (errnum)
 	    {
+#if defined USE_IN_LIBIO || _LIBC || HAVE_DECL_STRERROR_R
 	      char buf[200];
+#endif
 
 #ifdef USE_IN_LIBIO
 	      if (_IO_fwide (stream, 0) > 0)


[prev in list] [next in list] [prev in thread] [next in thread]