[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gnash-commit
Subject:    [Gnash-commit] [bug #50174] `make check` failed, due to ming-related link error
From:       Nutchanon Wetchasit <INVALID.NOREPLY () gnu ! org>
Date:       2017-01-29 13:59:48
Message-ID: 20170129-205947.sv82809.37484 () savannah ! gnu ! org
[Download RAW message or body]

Follow-up Comment #4, bug #50174 (project gnash):

From all said in previous posts, following changes need be introduced (on top
of culprit commit) to prevent testsuite build error and other version
detection anomalies:

* `macros/ming.m4` needs to be changed to trim leading zeroes from
`MING_VERSION_CODE` (possibly by passing it through `sed`).
* Leading zeros need to be trimmed from `#if MING_VERSION_CODE` comparison in
following files:
** testsuite/actionscript.all/enumerate.as 
** testsuite/actionscript.all/Matrix.as
** testsuite/actionscript.all/delete.as
** testsuite/actionscript.all/Try.as
** testsuite/actionscript.all/targetPath.as
** testsuite/actionscript.all/check.as
** testsuite/misc-ming.all/matrix_test.c
** testsuite/misc-ming.all/attachMovieTest.c
** testsuite/misc-ming.all/duplicate_movie_clip_test.c

(One can use `grep -nR MING_VERSION_CODE * | grep -Pi '\.(as|h|cc|cpp|c):'` in
Gnash source directory to find all of these, save for the M4 macro)

See the attached `0001_fix-ming-octal-version-inconsistency.patch` for a patch
which do these changes. On my machine, this patch allows `make check` to
complete with normal results; but not sure if my use of `sed` is portable
though.

Alternatively, the ff92e0a commit could be reverted (which works, in spite of
the octal number limitation <https://savannah.gnu.org/bugs/?50174#comment3>).

Gnash: 0.8.11dev (git ff92e0a 28-Jan-2017)
GCC: 4.7.2-5 (debian)
G++: 4.7.2-5 (debian)
Ming: 0.4.4-1.1 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386


(file #39605)
    _______________________________________________________

Additional Item Attachment:

File name: 0001_fix-ming-octal-version-inconsistency.patch Size:12 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?50174>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/


_______________________________________________
Gnash-commit mailing list
Gnash-commit@gnu.org
https://lists.gnu.org/mailman/listinfo/gnash-commit
[prev in list] [next in list] [prev in thread] [next in thread]