[prev in list] [next in list] [prev in thread] [next in thread]
List: gnash-commit
Subject: [Gnash-commit] [patch #8942] Patches to improve number value handling in ExternalInterface
From: Nutchanon Wetchasit <INVALID.NOREPLY () gnu ! org>
Date: 2016-03-13 12:57:35
Message-ID: 20160313-195734.sv82809.42746 () savannah ! gnu ! org
[Download RAW message or body]
URL:
<http://savannah.gnu.org/patch/?8942>
Summary: Patches to improve number value handling in
ExternalInterface
Project: Gnash - The GNU Flash player
Submitted by: nachanon
Submitted on: Sun 13 Mar 2016 07:57:34 PM ICT
Category: plugin
Priority: 5 - Normal
Status: None
Privacy: Public
Assigned to: None
Originator Email:
Open/Closed: Open
Discussion Lock: Any
_______________________________________________________
Details:
Current libgnashplugin's ExternalInterface data parser has
a problem unmarshalling `Number` value sent from Gnash (player) when
the number is a very large whole number, or is a special float value like
`Infinity`, `-Infinity`, and `NaN`. This is due to the parser selectively
parse number string without dot as integer
<https://savannah.gnu.org/bugs/?47280#comment3> (range `int32_t`).
Patch 1 of 2:
See the attached
`0001_always-parse-externalinterface-number-as-double.patch`.
This patch makes libgnashplugin always unmarshall `<number>` value sent
from Gnash player as `double`, which supports special value like infinity
and non-number value. This also make a large whole number correctly passed
as wider significand range is provided (53-bit instead of 32-bit).
This partially fixes bug #47280.
The change in type shouldn't cause problem, as
`ExternalInterface::parseXML()`
is only used for parsing return value for JavaScript-access call
(ExternalInterface and built-in Flash plugin functions).
Gnash: 0.8.11dev (patched against git a72afa5 9-Mar-2016) NPAPI
Browser: Iceweasel 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386
_______________________________________________________
File Attachments:
-------------------------------------------------------
Date: Sun 13 Mar 2016 07:57:34 PM ICT Name:
0001_always-parse-externalinterface-number-as-double.patch Size: 1kB By:
nachanon
Patch to make libgnashplugin always parse `<number>` as `double`
<http://savannah.gnu.org/patch/download.php?file_id=36618>
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/patch/?8942>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
_______________________________________________
Gnash-commit mailing list
Gnash-commit@gnu.org
https://lists.gnu.org/mailman/listinfo/gnash-commit
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic