[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gnash-commit
Subject:    [Gnash-commit] [patch #8721] Patch to make `GetVariable()` return String regardless of original vari
From:       Nutchanon Wetchasit <INVALID.NOREPLY () gnu ! org>
Date:       2015-08-28 13:16:04
Message-ID: 20150828-201604.sv82809.41033 () savannah ! gnu ! org
[Download RAW message or body]

Follow-up Comment #5, patch #8721 (project gnash):

For the behavior difference between Gnash and Flash, I have tested around
and found that this is not really caused by `as_object.get_member()`;
the function is actually working as advertised.

The problem seemed to root from the way Gnash deals with
*unassigned* `var` declaration *in timeline context*.

Excerpt from Gnash git's debug output (verbosity 2 + action error log)
when running `getvariable.html` test (file #34682):

124 ACTIONSCRIPT ERROR: The 'var whatever' syntax in timeline context is a
no-op.


This message is from the declaration of `var undefined_variable` used in
the test. This means that Gnash ignored the declaration and left the property
unset. Thus, `as_object.get_member()` reported `false` on the variable.

If the variable is declared with `var undefined_variable=undefined` instead,
`as_object.get_member()` will report the correct result.

This issue is now posted as a separate entry: bug #45840, test included.

If that bug is fixed, the proposed GetVariable() patch would automatically
give a correct output.

Gnash: 0.8.11dev (patched against git f341372 25-Aug-2015) NPAPI
Browser: Iceweasel 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386

(file #34761)
    _______________________________________________________

Additional Item Attachment:

File name: 0001_return-string-from-getvariable-v2.patch Size:1 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8721>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/


_______________________________________________
Gnash-commit mailing list
Gnash-commit@gnu.org
https://lists.gnu.org/mailman/listinfo/gnash-commit
[prev in list] [next in list] [prev in thread] [next in thread]